mirror/erigon-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/erigon-pulse.git synced 2024-12-22 11:41:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

devnet: fix infinite recursion & enable TestStateSync & TestCallContract integration tests (#9183)

Browse Source 
This PR fixes an infinite recursion (stack overflow) error in devnet
integration tests that surfaced in our integration CI a week or more ago
and additionally enables some integration tests that are now fixed -
`TestStateSync` & `TestCallContract`.

![Screenshot 2024-01-09 at 17 10
24](https://github.com/ledgerwatch/erigon/assets/94537774/a5a8c9c9-9f68-4084-9e08-1bf3c1601cab)
This commit is contained in:
milen 2024-01-09 20:02:14 +00:00 committed by GitHub
parent 8db023bea6
commit 0cfe6617db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/devnet/devnet/context.go
View File

@ -139,10 +139,8 @@ func CurrentNetwork(ctx context.Context) *Network {
return cn.network return cn.network
} }
if current := CurrentNode(ctx); current != nil { if cn, ok := ctx.Value(ckNode).(*cnode); ok && cn.node != nil {
if n, ok := current.(*devnetNode); ok { return cn.node.(*devnetNode).network
return n.network
}
} }
if devnet, ok := ctx.Value(ckDevnet).(Devnet); ok { if devnet, ok := ctx.Value(ckDevnet).(Devnet); ok {

5
cmd/devnet/tests/bor/devnet_test.go
View File

@ -6,18 +6,17 @@ import (
"context" "context"
"testing" "testing"
"github.com/stretchr/testify/require"
"github.com/ledgerwatch/erigon-lib/chain/networkname" "github.com/ledgerwatch/erigon-lib/chain/networkname"
accounts_steps "github.com/ledgerwatch/erigon/cmd/devnet/accounts/steps" accounts_steps "github.com/ledgerwatch/erigon/cmd/devnet/accounts/steps"
contracts_steps "github.com/ledgerwatch/erigon/cmd/devnet/contracts/steps" contracts_steps "github.com/ledgerwatch/erigon/cmd/devnet/contracts/steps"
"github.com/ledgerwatch/erigon/cmd/devnet/requests" "github.com/ledgerwatch/erigon/cmd/devnet/requests"
"github.com/ledgerwatch/erigon/cmd/devnet/services" "github.com/ledgerwatch/erigon/cmd/devnet/services"
"github.com/ledgerwatch/erigon/cmd/devnet/tests" "github.com/ledgerwatch/erigon/cmd/devnet/tests"
"github.com/stretchr/testify/require"
) )
func TestStateSync(t *testing.T) { func TestStateSync(t *testing.T) {
t.Skip("FIXME: hangs in GenerateSyncEvents without any visible progress")
runCtx, err := tests.ContextStart(t, networkname.BorDevnetChainName) runCtx, err := tests.ContextStart(t, networkname.BorDevnetChainName)
require.Nil(t, err) require.Nil(t, err)
var ctx context.Context = runCtx var ctx context.Context = runCtx

5
cmd/devnet/tests/generic/devnet_test.go
View File

@ -7,6 +7,8 @@ import (
"testing" "testing"
"time" "time"
"github.com/stretchr/testify/require"
"github.com/ledgerwatch/erigon/cmd/devnet/accounts" "github.com/ledgerwatch/erigon/cmd/devnet/accounts"
"github.com/ledgerwatch/erigon/cmd/devnet/admin" "github.com/ledgerwatch/erigon/cmd/devnet/admin"
"github.com/ledgerwatch/erigon/cmd/devnet/contracts/steps" "github.com/ledgerwatch/erigon/cmd/devnet/contracts/steps"
@ -14,7 +16,6 @@ import (
"github.com/ledgerwatch/erigon/cmd/devnet/services" "github.com/ledgerwatch/erigon/cmd/devnet/services"
"github.com/ledgerwatch/erigon/cmd/devnet/tests" "github.com/ledgerwatch/erigon/cmd/devnet/tests"
"github.com/ledgerwatch/erigon/cmd/devnet/transactions" "github.com/ledgerwatch/erigon/cmd/devnet/transactions"
"github.com/stretchr/testify/require"
) )
func testDynamicTx(t *testing.T, ctx context.Context) { func testDynamicTx(t *testing.T, ctx context.Context) {
@ -51,8 +52,6 @@ func TestDynamicTxAnyNode(t *testing.T) {
} }
func TestCallContract(t *testing.T) { func TestCallContract(t *testing.T) {
t.Skip("FIXME: DeployAndCallLogSubscriber step fails: Log result is incorrect expected txIndex: 1, actual txIndex 2")
runCtx, err := tests.ContextStart(t, "") runCtx, err := tests.ContextStart(t, "")
require.Nil(t, err) require.Nil(t, err)
ctx := runCtx.WithCurrentNetwork(0) ctx := runCtx.WithCurrentNetwork(0)