mirror/erigon-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/erigon-pulse.git synced 2025-01-13 14:30:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

miner: avoid sleeping in miner (#22108)

Browse Source 
This PR removes a logic in the miner, which was originally intended to help temporary testnets based on ethash from "running off into the future". If the difficulty was low, and a few computers started mining several blocks per second, the ethash rules (which demand 1s delay between blocks) would push the blocktimes further and further away.
The solution was to make the miner sleep while this happened.

Nowadays, this problem is solved instead by PoA chains, and it's recommended to let testnets and devnets be based on clique instead. The existing logic is problematic, since it can cause stalls within the miner making it difficult for remote workers to submit work if the channel is blocked on a sleep.

Credits to Saar Tochner for reporting this via the bug bounty
# Conflicts:
#	miner/worker.go
This commit is contained in:
Martin Holst Swende 2021-01-05 10:44:33 +01:00 committed by Igor Mandrigin
parent 7b9565fe10
commit 20413ad716
1 changed files with 0 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
diff.txt
View File

@ -1929,40 +1929,3 @@ Date: Tue Jan 5 10:44:33 2021 +0100
Nowadays, this problem is solved instead by PoA chains, and it's recommended to let testnets and devnets be based on clique instead. The existing logic is problematic, since it can cause stalls within the miner making it difficult for remote workers to submit work if the channel is blocked on a sleep.
Credits to Saar Tochner for reporting this via the bug bounty
commit 6ada9f0f38d14941ab02144319dba9482da18da5
Merge: 1951e20d1 e4571d8c1
Author: Péter Szilágyi <peterke@gmail.com>
Date: Tue Jan 5 10:27:33 2021 +0200
Merge pull request #22107 from karalabe/faucet-twitter
cmd: support v1.1 Twitter API in faucet, fix puppeth
commit e4571d8c12be5aaa380ee58ea35a5617823e5324
Author: Péter Szilágyi <peterke@gmail.com>
Date: Mon Jan 4 13:58:46 2021 +0200
cmd: support v1.1 Twitter API in faucet, fix puppeth
commit 1951e20d1040627faf3b6722c88ddf0e86ecf50e
Author: Suriyaa Sundararuban <isc.suriyaa@gmail.com>
Date: Mon Jan 4 12:42:47 2021 +0100
SECURITY.md: link to release page (#22067)
Add links to go-ethereum's GitHub release page.
Co-authored-by: Felix Lange <fjl@twurst.com>
commit 5c2a7ce2ccace9f453bcd320b4ac52e1f5ce3ab2
Author: rene <41963722+renaynay@users.noreply.github.com>
Date: Mon Jan 4 12:39:25 2021 +0100
node: rename startNetworking to openEndpoints (#22105)
commit 47820ef726a7b08ea2e22baff8fff64231c3046b
Author: Suriyaa Sundararuban <isc.suriyaa@gmail.com>
Date: Mon Jan 4 11:58:51 2021 +0100
.github: Replace wiki links with new doc pages (#22065) (#22068)