mirror/erigon-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/erigon-pulse.git synced 2024-12-22 03:30:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoiding leaking the popped item (#6193)

Browse Source 
Set the deleted item to its zero val so it can be garbage collected.
This commit is contained in:
Håvard Anda Estensen 2022-12-04 05:17:02 +01:00 committed by GitHub
parent 099fb7c627
commit 31ec791d5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/sentry/sentry/sentry_grpc_server.go
View File

@ -105,6 +105,7 @@ func (bp *PeersByMinBlock) Pop() interface{} {
old := *bp old := *bp
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = PeerRef{}
*bp = old[0 : n-1] *bp = old[0 : n-1]
return x return x
} }

1
core/types/transaction.go
View File

@ -319,6 +319,7 @@ func (s *TxByPriceAndTime) Pop() interface{} {
old := *s old := *s
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = nil
*s = old[0 : n-1] *s = old[0 : n-1]
return x return x
} }

2
eth/gasprice/gasprice.go
View File

@ -211,6 +211,7 @@ func (t *transactionsByGasPrice) Pop() interface{} {
old := t.txs old := t.txs
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = nil
t.txs = old[0 : n-1] t.txs = old[0 : n-1]
return x return x
} }
@ -289,6 +290,7 @@ func (s *sortingHeap) Pop() interface{} {
old := *s old := *s
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = nil
*s = old[0 : n-1] *s = old[0 : n-1]
return x return x
} }

1
p2p/util.go
View File

@ -70,6 +70,7 @@ func (h *expHeap) Pop() interface{} {
old := *h old := *h
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = expItem{}
*h = old[0 : n-1] *h = old[0 : n-1]
return x return x
} }

3
turbo/stages/headerdownload/header_data_struct.go
View File

@ -87,6 +87,7 @@ func (lq *LinkQueue) Pop() interface{} {
old := *lq old := *lq
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = nil
x.idx = -1 x.idx = -1
x.queueId = NoQueue x.queueId = NoQueue
*lq = old[0 : n-1] *lq = old[0 : n-1]
@ -152,6 +153,7 @@ func (aq *AnchorQueue) Pop() interface{} {
old := *aq old := *aq
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = nil
*aq = old[0 : n-1] *aq = old[0 : n-1]
x.idx = -1 x.idx = -1
return x return x
@ -243,6 +245,7 @@ func (iq *InsertQueue) Pop() interface{} {
old := *iq old := *iq
n := len(old) n := len(old)
x := old[n-1] x := old[n-1]
old[n-1] = nil
*iq = old[0 : n-1] *iq = old[0 : n-1]
x.idx = -1 x.idx = -1
x.queueId = NoQueue x.queueId = NoQueue