mirror/erigon-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/erigon-pulse.git synced 2025-01-01 00:31:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

txpool: prevent index out of range (#690)

Browse Source 
This is to prevent the following error reported by stickx:

![PXL_20221020_010643559](https://user-images.githubusercontent.com/34320705/196905773-5a9fee50-53a1-494e-ae44-2eae40d0c972.jpeg)
This commit is contained in:
Andrew Ashikhmin 2022-10-20 11:14:41 +02:00 committed by GitHub
parent ea2db04e93
commit 88e80dac7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
txpool/pool.go
View File

@ -604,7 +604,7 @@ func (p *TxPool) AddNewGoodPeer(peerID types.PeerID) { p.recentlyConnectedPeers.
func (p *TxPool) Started() bool { return p.started.Load() } func (p *TxPool) Started() bool { return p.started.Load() }
// Best - returns top `n` elements of pending queue // Best - returns top `n` elements of pending queue
// id doesn't perform full copy of txs, hovewer underlying elements are immutable // id doesn't perform full copy of txs, however underlying elements are immutable
func (p *TxPool) Best(n uint16, txs *types.TxsRlp, tx kv.Tx, onTopOf uint64) (bool, error) { func (p *TxPool) Best(n uint16, txs *types.TxsRlp, tx kv.Tx, onTopOf uint64) (bool, error) {
// First wait for the corresponding block to arrive // First wait for the corresponding block to arrive
if p.lastSeenBlock.Load() < onTopOf { if p.lastSeenBlock.Load() < onTopOf {
@ -2070,8 +2070,12 @@ func (p *PendingPool) Updated(mt *metaTx) {
func (p *PendingPool) Len() int { return len(p.best.ms) } func (p *PendingPool) Len() int { return len(p.best.ms) }
func (p *PendingPool) Remove(i *metaTx) { func (p *PendingPool) Remove(i *metaTx) {
if i.worstIndex >= 0 {
heap.Remove(p.worst, i.worstIndex) heap.Remove(p.worst, i.worstIndex)
}
if i.bestIndex >= 0 {
p.best.UnsafeRemove(i) p.best.UnsafeRemove(i)
}
i.currentSubPool = 0 i.currentSubPool = 0
} }