mirror/erigon-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/erigon-pulse.git synced 2024-12-31 16:21:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Check existence before write - because WriteRawBody isn't idempotent (it allocates new sequence range for transactions on every call) (#2941)

Browse Source
This commit is contained in:
Alex Sharov 2021-11-11 10:17:33 +07:00 committed by GitHub
parent ab4c080cbc
commit 95c0e45cfa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
eth/stagedsync/stage_bodies.go
View File

@ -10,6 +10,7 @@ import (
libcommon "github.com/ledgerwatch/erigon-lib/common"
"github.com/ledgerwatch/erigon-lib/kv"
"github.com/ledgerwatch/erigon/common"
"github.com/ledgerwatch/erigon/common/dbutils"
"github.com/ledgerwatch/erigon/core/rawdb"
"github.com/ledgerwatch/erigon/eth/stagedsync/stages"
"github.com/ledgerwatch/erigon/params"
@ -158,12 +159,20 @@ Loop:
u.UnwindTo(blockHeight-1, header.Hash())
break Loop
}
if err = rawdb.WriteRawBody(tx, header.Hash(), blockHeight, rawBody); err != nil {
return fmt.Errorf("writing block body: %w", err)
// Check existence before write - because WriteRawBody isn't idempotent (it allocates new sequence range for transactions on every call)
exists, err := tx.Has(kv.BlockBody, dbutils.BlockBodyKey(blockHeight, header.Hash()))
if err != nil {
return err
}
if !exists {
if err = rawdb.WriteRawBody(tx, header.Hash(), blockHeight, rawBody); err != nil {
return fmt.Errorf("writing block body: %w", err)
}
}
if blockHeight > bodyProgress {
bodyProgress = blockHeight
if err = stages.SaveStageProgress(tx, stages.Bodies, blockHeight); err != nil {
if err = s.Update(tx, blockHeight); err != nil {
return fmt.Errorf("saving Bodies progress: %w", err)
}
}