mirror/erigon-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/erigon-pulse.git synced 2025-01-16 07:48:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixup for a possible deadlock if db.env.BeginTxn fails (#516)

Browse Source 
* attempt to fix the deadlock

* slightly more correct check

Co-authored-by: Igor Mandrigin <i@mandrigin.ru>
This commit is contained in:
Igor Mandrigin 2022-07-07 08:52:30 +02:00 committed by GitHub
parent a86baf3e81
commit 95e361fa1e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
kv/mdbx/kv_mdbx.go
View File

@ -402,6 +402,11 @@ func (db *MdbxKV) BeginRo(ctx context.Context) (txn kv.Tx, err error) {
if err == nil { if err == nil {
db.wg.Add(1) db.wg.Add(1)
} }
if txn == nil {
// on error, or if there is whatever reason that we don't return a tx,
// we need to free up the limiter slot, otherwise it could lead to deadlocks
<-db.roTxsLimiter
}
}() }()
tx, err := db.env.BeginTxn(nil, mdbx.Readonly) tx, err := db.env.BeginTxn(nil, mdbx.Readonly)