From edcd7fcd63f41bbda345c1bae2db22a4bdb9796c Mon Sep 17 00:00:00 2001 From: ddl Date: Wed, 6 Dec 2023 10:23:43 +0800 Subject: [PATCH] update outdated information (#8906) 1. When running locally, found that these **TODO** json-rpc have been implemented. Updating these outdated information can make the document clearer. ``` curl -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_newBlockFilter","params":[],"id":1}' http://loca lhost:8545 {"jsonrpc":"2.0","id":1,"result":"0x02000000000000009c49b60f431cabc7"} ``` 2. [but it's easy to accomplish] Points to an obsolete message (https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673) --- README.md | 8 +------- docs/mining.md | 7 ------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/README.md b/README.md index 248de8df7..7ada8d94f 100644 --- a/README.md +++ b/README.md @@ -194,13 +194,7 @@ Support only remote-miners. , `--miner.gastarget` * JSON-RPC supports methods: eth_coinbase , eth_hashrate, eth_mining, eth_getWork, eth_submitWork, eth_submitHashrate * JSON-RPC supports websocket methods: newPendingTransaction -* TODO: - + we don't broadcast mined blocks to p2p-network - yet, [but it's easy to accomplish](https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673) - + eth_newPendingTransactionFilter - + eth_newBlockFilter - + eth_newFilter - + websocket Logs + 🔬 Detailed explanation is [here](/docs/mining.md). diff --git a/docs/mining.md b/docs/mining.md index c85333f85..c84a4013f 100644 --- a/docs/mining.md +++ b/docs/mining.md @@ -24,10 +24,3 @@ to `integration state_stages` command: ``` ./build/bin/integration state_stages --datadir= --unwind=1 --unwind.every=2 --integrity.fast=false --integrity.slow=false --mine --miner.etherbase= ``` - -* TODO: - + we don't broadcast mined blocks to p2p-network yet, [but it's easy to accomplish](https://github.com/ledgerwatch/erigon/blob/9b8cdc0f2289a7cef78218a15043de5bdff4465e/eth/downloader/downloader.go#L673) - + eth_newPendingTransactionFilter - + eth_newBlockFilter - + eth_newFilter - + websocket Logs