erigon-pulse/crypto
Felix Lange 5f7826270c all: unify big.Int zero checks, use common/math in more places (#3716)
* common/math: optimize PaddedBigBytes, use it more

name              old time/op    new time/op    delta
PaddedBigBytes-8    71.1ns ± 5%    46.1ns ± 1%  -35.15%  (p=0.000 n=20+19)

name              old alloc/op   new alloc/op   delta
PaddedBigBytes-8     48.0B ± 0%     32.0B ± 0%  -33.33%  (p=0.000 n=20+20)

* all: unify big.Int zero checks

Various checks were in use. This commit replaces them all with Int.Sign,
which is cheaper and less code.

eg templates:

    func before(x *big.Int) bool { return x.BitLen() == 0 }
    func after(x *big.Int) bool  { return x.Sign() == 0 }

    func before(x *big.Int) bool { return x.BitLen() > 0 }
    func after(x *big.Int) bool  { return x.Sign() != 0 }

    func before(x *big.Int) int { return x.Cmp(common.Big0) }
    func after(x *big.Int) int  { return x.Sign() }

* common/math, crypto/secp256k1: make ReadBits public in package math
2017-02-28 15:09:11 +01:00
..
ecies crypto: add btcec fallback for sign/recover without cgo (#3680) 2017-02-18 09:24:12 +01:00
randentropy crypto: Remove dead code 2016-02-21 22:46:31 +00:00
secp256k1 all: unify big.Int zero checks, use common/math in more places (#3716) 2017-02-28 15:09:11 +01:00
sha3 all: gofmt -w -s 2017-01-06 15:52:03 +01:00
crypto_test.go crypto: add btcec fallback for sign/recover without cgo (#3680) 2017-02-18 09:24:12 +01:00
crypto.go common: move big integer math to common/math (#3699) 2017-02-26 22:21:51 +01:00
signature_cgo.go all: unify big.Int zero checks, use common/math in more places (#3716) 2017-02-28 15:09:11 +01:00
signature_nocgo.go crypto: add btcec fallback for sign/recover without cgo (#3680) 2017-02-18 09:24:12 +01:00
signature_test.go crypto: add btcec fallback for sign/recover without cgo (#3680) 2017-02-18 09:24:12 +01:00