erigon-pulse/internal
gary rong ad9e4241b1 all: seperate consensus error and evm internal error (#20830)
* all: seperate consensus error and evm internal error

There are actually two types of error will be returned when
a tranaction/message call is executed: (a) consensus error
(b) evm internal error. The former should be converted to
a consensus issue, e.g. The sender doesn't enough asset to
purchase the gas it specifies. The latter is allowed since
evm itself is a blackbox and internal error is allowed to happen.

This PR emphasizes the difference by introducing a executionResult
structure. The evm error is embedded inside. So if any error
returned, it indicates consensus issue happens.

And also this PR improve the `EstimateGas` API to return the concrete
revert reason if the transaction always fails

* all: polish

* accounts/abi/bind/backends: add tests

* accounts/abi/bind/backends, internal: cleanup error message

* all: address comments

* core: fix lint

* accounts, core, eth, internal: address comments

* accounts, internal: resolve revert reason if possible

* accounts, internal: address comments
# Conflicts:
#	accounts/abi/abi.go
#	accounts/abi/bind/backends/simulated.go
#	cmd/geth/retesteth.go
#	core/state/snapshot/difflayer_test.go
#	core/state/snapshot/disklayer_test.go
#	core/state/snapshot/iterator_test.go
#	core/state_processor.go
#	core/state_transition.go
#	core/vm/evm.go
#	core/vm/instructions.go
#	core/vm/jump_table.go
#	eth/api_tracer.go
#	internal/ethapi/api.go
#	les/odr_test.go
#	light/odr_test.go
#	tests/state_test_util.go
2020-05-20 15:26:22 +03:00
..
build internal/build: don't crash in DownloadFile when offline (#20595) 2020-02-27 17:20:36 +03:00
cmdtest internal: fix staticcheck warnings (#20380) 2019-12-09 12:12:12 +01:00
debug Metrics server without pprof (#451) 2020-04-14 13:49:49 +01:00
ethapi all: seperate consensus error and evm internal error (#20830) 2020-05-20 15:26:22 +03:00
guide Apply Turbo-Geth modifications to go-ethereum codebase 2019-11-01 21:52:03 +01:00
jsre post-merge fixups 2020-02-27 17:22:25 +03:00
testlog internal/testlog: print file+line number of log call in test log (#20528) 2020-01-30 13:36:30 +02:00
web3ext geth 1.9.13 (#469) 2020-04-19 18:31:47 +01:00