mirror of
https://gitlab.com/pulsechaincom/erigon-pulse.git
synced 2024-12-26 05:27:19 +00:00
961a0070cc
So there is an issue with tracing certain blocks/transactions on
Polygon, for example:
```
> '{"method": "trace_transaction","params":["0xb198d93f640343a98f90d93aa2b74b4fc5c64f3a649f1608d2bfd1004f9dee0e"],"id":1,"jsonrpc":"2.0"}'
```
gives the error `first run for txIndex 1 error: insufficient funds for
gas * price + value: address 0x10AD27A96CDBffC90ab3b83bF695911426A69f5E
have 16927727762862809 want 17594166808296934`
The reason is that this transaction is from the author of the block,
which doesn't have enough ETH to pay for the gas fee + tx value if he's
not the block author receiving transactions fees.
The issue is that currently the APIs are using `ethash.NewFaker()`
Engine for running traces, etc. which doesn't know how to get the author
for a specific block (which is consensus dependant); as it was noting in
several TODO comments.
The fix is to pass the Engine to the BaseAPI, which can then be used to
create the right Block Context. I chose to split the current Engine
interface in 2, with Reader and Writer, so that the BaseAPI only
receives the Reader one, which might be safer (even though it's only
used for getting the block Author).
288 lines
9.7 KiB
Go
288 lines
9.7 KiB
Go
package commands
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/holiman/uint256"
|
|
jsoniter "github.com/json-iterator/go"
|
|
"github.com/ledgerwatch/erigon-lib/kv/kvcache"
|
|
"github.com/ledgerwatch/erigon/cmd/rpcdaemon/cli/httpcfg"
|
|
"github.com/ledgerwatch/erigon/eth/ethconfig"
|
|
"github.com/ledgerwatch/erigon/rpc/rpccfg"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/valyala/fastjson"
|
|
|
|
"github.com/ledgerwatch/erigon/common"
|
|
"github.com/ledgerwatch/erigon/common/hexutil"
|
|
"github.com/ledgerwatch/erigon/core"
|
|
"github.com/ledgerwatch/erigon/core/types"
|
|
"github.com/ledgerwatch/erigon/turbo/snapshotsync"
|
|
"github.com/ledgerwatch/erigon/turbo/stages"
|
|
)
|
|
|
|
func blockNumbersFromTraces(t *testing.T, b []byte) []int {
|
|
t.Helper()
|
|
var err error
|
|
var p fastjson.Parser
|
|
response := b
|
|
var v *fastjson.Value
|
|
if v, err = p.ParseBytes(response); err != nil {
|
|
t.Fatalf("parsing response: %v", err)
|
|
}
|
|
var elems []*fastjson.Value
|
|
if elems, err = v.Array(); err != nil {
|
|
t.Fatalf("expected array in the response: %v", err)
|
|
}
|
|
numbers := make([]int, 0, len(elems))
|
|
for _, elem := range elems {
|
|
bn := elem.GetInt("blockNumber")
|
|
numbers = append(numbers, bn)
|
|
}
|
|
return numbers
|
|
}
|
|
|
|
func TestCallTraceOneByOne(t *testing.T) {
|
|
if ethconfig.EnableHistoryV3InTest {
|
|
t.Skip("history.v3 doesn't store receipts in db")
|
|
}
|
|
m := stages.Mock(t)
|
|
chain, err := core.GenerateChain(m.ChainConfig, m.Genesis, m.Engine, m.DB, 10, func(i int, gen *core.BlockGen) {
|
|
gen.SetCoinbase(common.Address{1})
|
|
}, false /* intermediateHashes */)
|
|
if err != nil {
|
|
t.Fatalf("generate chain: %v", err)
|
|
}
|
|
|
|
agg := m.HistoryV3Components()
|
|
br := snapshotsync.NewBlockReaderWithSnapshots(m.BlockSnapshots)
|
|
api := NewTraceAPI(
|
|
NewBaseApi(nil, kvcache.New(kvcache.DefaultCoherentConfig), br, agg, false, rpccfg.DefaultEvmCallTimeout, m.Engine),
|
|
m.DB, &httpcfg.HttpCfg{})
|
|
// Insert blocks 1 by 1, to tirgget possible "off by one" errors
|
|
for i := 0; i < chain.Length(); i++ {
|
|
if err = m.InsertChain(chain.Slice(i, i+1)); err != nil {
|
|
t.Fatalf("inserting chain: %v", err)
|
|
}
|
|
}
|
|
stream := jsoniter.ConfigDefault.BorrowStream(nil)
|
|
defer jsoniter.ConfigDefault.ReturnStream(stream)
|
|
var fromBlock, toBlock uint64
|
|
fromBlock = 1
|
|
toBlock = 10
|
|
toAddress1 := common.Address{1}
|
|
traceReq1 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
ToAddress: []*common.Address{&toAddress1},
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq1, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
assert.Equal(t, []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}, blockNumbersFromTraces(t, stream.Buffer()))
|
|
}
|
|
|
|
func TestCallTraceUnwind(t *testing.T) {
|
|
if ethconfig.EnableHistoryV3InTest {
|
|
t.Skip("history.v3 doesn't store receipts in db")
|
|
}
|
|
m := stages.Mock(t)
|
|
var chainA, chainB *core.ChainPack
|
|
var err error
|
|
chainA, err = core.GenerateChain(m.ChainConfig, m.Genesis, m.Engine, m.DB, 10, func(i int, gen *core.BlockGen) {
|
|
gen.SetCoinbase(common.Address{1})
|
|
}, false /* intermediateHashes */)
|
|
if err != nil {
|
|
t.Fatalf("generate chainA: %v", err)
|
|
}
|
|
chainB, err = core.GenerateChain(m.ChainConfig, m.Genesis, m.Engine, m.DB, 20, func(i int, gen *core.BlockGen) {
|
|
if i < 5 || i >= 10 {
|
|
gen.SetCoinbase(common.Address{1})
|
|
} else {
|
|
gen.SetCoinbase(common.Address{2})
|
|
}
|
|
}, false /* intermediateHashes */)
|
|
if err != nil {
|
|
t.Fatalf("generate chainB: %v", err)
|
|
}
|
|
|
|
agg := m.HistoryV3Components()
|
|
br := snapshotsync.NewBlockReaderWithSnapshots(m.BlockSnapshots)
|
|
api := NewTraceAPI(NewBaseApi(nil, kvcache.New(kvcache.DefaultCoherentConfig), br, agg, false, rpccfg.DefaultEvmCallTimeout, m.Engine), m.DB, &httpcfg.HttpCfg{})
|
|
if err = m.InsertChain(chainA); err != nil {
|
|
t.Fatalf("inserting chainA: %v", err)
|
|
}
|
|
var buf bytes.Buffer
|
|
stream := jsoniter.NewStream(jsoniter.ConfigDefault, &buf, 4096)
|
|
var fromBlock, toBlock uint64
|
|
fromBlock = 1
|
|
toBlock = 10
|
|
toAddress1 := common.Address{1}
|
|
traceReq1 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
ToAddress: []*common.Address{&toAddress1},
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq1, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
assert.Equal(t, []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}, blockNumbersFromTraces(t, buf.Bytes()))
|
|
|
|
if err = m.InsertChain(chainB.Slice(0, 12)); err != nil {
|
|
t.Fatalf("inserting chainB: %v", err)
|
|
}
|
|
buf.Reset()
|
|
toBlock = 12
|
|
traceReq2 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
ToAddress: []*common.Address{&toAddress1},
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq2, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
assert.Equal(t, []int{1, 2, 3, 4, 5, 11, 12}, blockNumbersFromTraces(t, buf.Bytes()))
|
|
|
|
if err = m.InsertChain(chainB.Slice(12, 20)); err != nil {
|
|
t.Fatalf("inserting chainB: %v", err)
|
|
}
|
|
buf.Reset()
|
|
fromBlock = 12
|
|
toBlock = 20
|
|
traceReq3 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
ToAddress: []*common.Address{&toAddress1},
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq3, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
assert.Equal(t, []int{12, 13, 14, 15, 16, 17, 18, 19, 20}, blockNumbersFromTraces(t, buf.Bytes()))
|
|
}
|
|
|
|
func TestFilterNoAddresses(t *testing.T) {
|
|
m := stages.Mock(t)
|
|
if m.HistoryV3 {
|
|
t.Skip()
|
|
}
|
|
chain, err := core.GenerateChain(m.ChainConfig, m.Genesis, m.Engine, m.DB, 10, func(i int, gen *core.BlockGen) {
|
|
gen.SetCoinbase(common.Address{1})
|
|
}, false /* intermediateHashes */)
|
|
if err != nil {
|
|
t.Fatalf("generate chain: %v", err)
|
|
}
|
|
agg := m.HistoryV3Components()
|
|
br := snapshotsync.NewBlockReaderWithSnapshots(m.BlockSnapshots)
|
|
api := NewTraceAPI(NewBaseApi(nil, kvcache.New(kvcache.DefaultCoherentConfig), br, agg, false, rpccfg.DefaultEvmCallTimeout, m.Engine), m.DB, &httpcfg.HttpCfg{})
|
|
// Insert blocks 1 by 1, to tirgget possible "off by one" errors
|
|
for i := 0; i < chain.Length(); i++ {
|
|
if err = m.InsertChain(chain.Slice(i, i+1)); err != nil {
|
|
t.Fatalf("inserting chain: %v", err)
|
|
}
|
|
}
|
|
var buf bytes.Buffer
|
|
stream := jsoniter.NewStream(jsoniter.ConfigDefault, &buf, 4096)
|
|
var fromBlock, toBlock uint64
|
|
fromBlock = 1
|
|
toBlock = 10
|
|
traceReq1 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq1, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
assert.Equal(t, []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10}, blockNumbersFromTraces(t, buf.Bytes()))
|
|
}
|
|
|
|
func TestFilterAddressIntersection(t *testing.T) {
|
|
if ethconfig.EnableHistoryV3InTest {
|
|
t.Skip("history.v3 doesn't store receipts in db")
|
|
}
|
|
|
|
m := stages.Mock(t)
|
|
agg := m.HistoryV3Components()
|
|
br := snapshotsync.NewBlockReaderWithSnapshots(m.BlockSnapshots)
|
|
api := NewTraceAPI(NewBaseApi(nil, kvcache.New(kvcache.DefaultCoherentConfig), br, agg, false, rpccfg.DefaultEvmCallTimeout, m.Engine), m.DB, &httpcfg.HttpCfg{})
|
|
|
|
toAddress1, toAddress2, other := common.Address{1}, common.Address{2}, common.Address{3}
|
|
|
|
once := new(sync.Once)
|
|
chain, err := core.GenerateChain(m.ChainConfig, m.Genesis, m.Engine, m.DB, 15, func(i int, block *core.BlockGen) {
|
|
once.Do(func() { block.SetCoinbase(common.Address{4}) })
|
|
|
|
var rcv common.Address
|
|
if i < 5 {
|
|
rcv = toAddress1
|
|
} else if i < 10 {
|
|
rcv = toAddress2
|
|
} else {
|
|
rcv = other
|
|
}
|
|
|
|
signer := types.LatestSigner(m.ChainConfig)
|
|
txn, err := types.SignTx(types.NewTransaction(block.TxNonce(m.Address), rcv, new(uint256.Int), 21000, new(uint256.Int), nil), *signer, m.Key)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
block.AddTx(txn)
|
|
}, false /* intermediateHashes */)
|
|
require.NoError(t, err, "generate chain")
|
|
|
|
err = m.InsertChain(chain)
|
|
require.NoError(t, err, "inserting chain")
|
|
|
|
fromBlock, toBlock := uint64(1), uint64(15)
|
|
t.Run("second", func(t *testing.T) {
|
|
stream := jsoniter.ConfigDefault.BorrowStream(nil)
|
|
defer jsoniter.ConfigDefault.ReturnStream(stream)
|
|
|
|
traceReq1 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
FromAddress: []*common.Address{&m.Address, &other},
|
|
ToAddress: []*common.Address{&m.Address, &toAddress2},
|
|
Mode: TraceFilterModeIntersection,
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq1, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
assert.Equal(t, []int{6, 7, 8, 9, 10}, blockNumbersFromTraces(t, stream.Buffer()))
|
|
})
|
|
t.Run("first", func(t *testing.T) {
|
|
stream := jsoniter.ConfigDefault.BorrowStream(nil)
|
|
defer jsoniter.ConfigDefault.ReturnStream(stream)
|
|
|
|
traceReq1 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
FromAddress: []*common.Address{&m.Address, &other},
|
|
ToAddress: []*common.Address{&toAddress1, &m.Address},
|
|
Mode: TraceFilterModeIntersection,
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq1, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
assert.Equal(t, []int{1, 2, 3, 4, 5}, blockNumbersFromTraces(t, stream.Buffer()))
|
|
})
|
|
t.Run("empty", func(t *testing.T) {
|
|
stream := jsoniter.ConfigDefault.BorrowStream(nil)
|
|
defer jsoniter.ConfigDefault.ReturnStream(stream)
|
|
|
|
traceReq1 := TraceFilterRequest{
|
|
FromBlock: (*hexutil.Uint64)(&fromBlock),
|
|
ToBlock: (*hexutil.Uint64)(&toBlock),
|
|
ToAddress: []*common.Address{&other},
|
|
FromAddress: []*common.Address{&toAddress2, &toAddress1, &other},
|
|
Mode: TraceFilterModeIntersection,
|
|
}
|
|
if err = api.Filter(context.Background(), traceReq1, stream); err != nil {
|
|
t.Fatalf("trace_filter failed: %v", err)
|
|
}
|
|
require.Empty(t, blockNumbersFromTraces(t, stream.Buffer()))
|
|
})
|
|
}
|