erigon-pulse/accounts/keystore
Felix Lange 5f7826270c all: unify big.Int zero checks, use common/math in more places (#3716)
* common/math: optimize PaddedBigBytes, use it more

name              old time/op    new time/op    delta
PaddedBigBytes-8    71.1ns ± 5%    46.1ns ± 1%  -35.15%  (p=0.000 n=20+19)

name              old alloc/op   new alloc/op   delta
PaddedBigBytes-8     48.0B ± 0%     32.0B ± 0%  -33.33%  (p=0.000 n=20+20)

* all: unify big.Int zero checks

Various checks were in use. This commit replaces them all with Int.Sign,
which is cheaper and less code.

eg templates:

    func before(x *big.Int) bool { return x.BitLen() == 0 }
    func after(x *big.Int) bool  { return x.Sign() == 0 }

    func before(x *big.Int) bool { return x.BitLen() > 0 }
    func after(x *big.Int) bool  { return x.Sign() != 0 }

    func before(x *big.Int) int { return x.Cmp(common.Big0) }
    func after(x *big.Int) int  { return x.Sign() }

* common/math, crypto/secp256k1: make ReadBits public in package math
2017-02-28 15:09:11 +01:00
..
testdata accounts, cmd, eth, internal, mobile, node: split account backends 2017-02-13 14:00:02 +02:00
account_cache_test.go accounts: ledger and HD review fixes 2017-02-13 14:00:12 +02:00
account_cache.go accounts, eth/downloader: use "err" instead of "error" in logs 2017-02-27 13:17:58 +02:00
key.go crypto: add btcec fallback for sign/recover without cgo (#3680) 2017-02-18 09:24:12 +01:00
keystore_passphrase_test.go accounts, cmd, eth, internal, mobile, node: split account backends 2017-02-13 14:00:02 +02:00
keystore_passphrase.go all: unify big.Int zero checks, use common/math in more places (#3716) 2017-02-28 15:09:11 +01:00
keystore_plain_test.go accounts, cmd, internal, mobile, node: canonical account URLs 2017-02-13 14:00:08 +02:00
keystore_plain.go accounts, cmd, eth, internal, mobile, node: split account backends 2017-02-13 14:00:02 +02:00
keystore_test.go accounts: ledger and HD review fixes 2017-02-13 14:00:12 +02:00
keystore_wallet.go accounts, cmd, internal, node: implement HD wallet self-derivation 2017-02-13 14:00:09 +02:00
keystore.go accounts, cmd, internal, mobile, node: canonical account URLs 2017-02-13 14:00:08 +02:00
presale.go accounts, cmd, internal, mobile, node: canonical account URLs 2017-02-13 14:00:08 +02:00
watch_fallback.go accounts, cmd, eth, internal, miner, node: wallets and HD APIs 2017-02-13 14:00:07 +02:00
watch.go accounts, eth/downloader: use "err" instead of "error" in logs 2017-02-27 13:17:58 +02:00