erigon-pulse/swarm
Felix Lange 5f7826270c all: unify big.Int zero checks, use common/math in more places (#3716)
* common/math: optimize PaddedBigBytes, use it more

name              old time/op    new time/op    delta
PaddedBigBytes-8    71.1ns ± 5%    46.1ns ± 1%  -35.15%  (p=0.000 n=20+19)

name              old alloc/op   new alloc/op   delta
PaddedBigBytes-8     48.0B ± 0%     32.0B ± 0%  -33.33%  (p=0.000 n=20+20)

* all: unify big.Int zero checks

Various checks were in use. This commit replaces them all with Int.Sign,
which is cheaper and less code.

eg templates:

    func before(x *big.Int) bool { return x.BitLen() == 0 }
    func after(x *big.Int) bool  { return x.Sign() == 0 }

    func before(x *big.Int) bool { return x.BitLen() > 0 }
    func after(x *big.Int) bool  { return x.Sign() != 0 }

    func before(x *big.Int) int { return x.Cmp(common.Big0) }
    func after(x *big.Int) int  { return x.Sign() }

* common/math, crypto/secp256k1: make ReadBits public in package math
2017-02-28 15:09:11 +01:00
..
api eth, les, swarm: fix go vet issues sufraced by log15 2017-02-23 12:16:45 +02:00
network all: disable log message colors outside of geth 2017-02-27 15:33:12 +01:00
services/swap all: unify big.Int zero checks, use common/math in more places (#3716) 2017-02-28 15:09:11 +01:00
storage all: blidly swap out glog to our log15, logs need rework 2017-02-23 12:16:44 +02:00
swarm.go eth, les, swarm: fix go vet issues sufraced by log15 2017-02-23 12:16:45 +02:00