erigon-pulse/core/vm
Martin Holst Swende a4b70f9ee9 core/vm: less allocations for various call variants (#21222)
* core/vm/runtime/tests: add more benchmarks

* core/vm: initial work on improving alloc count for calls to precompiles

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6     117ms ±75%      43ms ± 1%  -63.09%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   79.6ms ± 4%    70.5ms ± 1%  -11.42%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    24.4MB ± 0%     4.9MB ± 0%  -79.94%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 0%    13.2kB ± 0%     ~     (p=0.357 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6      382k ± 0%      153k ± 0%  -59.99%  (p=0.000 n=5+4)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* core/vm: don't allocate big.int for touch

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6    43.3ms ± 1%    42.4ms ± 7%     ~     (p=0.151 n=5+5)
SimpleLoop/loop-10M-6                   70.5ms ± 1%    76.7ms ± 1%   +8.67%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    4.90MB ± 0%    2.46MB ± 0%  -49.83%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 0%    13.2kB ± 1%     ~     (p=0.571 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6      153k ± 0%       76k ± 0%  -49.98%  (p=0.029 n=4+4)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* core/vm: reduce allocs in staticcall

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6    42.4ms ± 7%    37.5ms ± 6%  -11.68%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   76.7ms ± 1%    69.1ms ± 1%   -9.82%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    2.46MB ± 0%    0.02MB ± 0%  -99.35%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 1%    13.2kB ± 0%     ~     (p=0.143 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6     76.4k ± 0%      0.1k ± 0%     ~     (p=0.079 n=4+5)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* trie: better use of hasher keccakState

* core/state/statedb: reduce allocations in getDeletedStateObject

* core/vm: reduce allocations in all call derivates

* core/vm: reduce allocations in call variants

- Make returnstack `uint32`
- Use a `sync.Pool` of `stack`s

* core/vm: fix tests

* core/vm: goimports

* core/vm: tracer fix + staticcall gas fix

* core/vm: add back snapshot to staticcall

* core/vm: review concerns + make returnstack pooled + enable returndata in traces

* core/vm: fix some test tracer method signatures

* core/vm: run gencodec, minor comment polish

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
# Conflicts:
#	core/state/statedb.go
#	core/vm/contracts_test.go
#	core/vm/evm.go
#	core/vm/instructions.go
#	core/vm/interpreter.go
#	core/vm/logger.go
#	core/vm/logger_json.go
#	core/vm/logger_test.go
#	core/vm/runtime/runtime_test.go
#	core/vm/stack/stack.go
#	eth/tracers/tracer.go
#	eth/tracers/tracer_test.go
#	trie/secure_trie.go
2020-08-07 13:46:26 +02:00
..
runtime core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
stack core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
testdata core/vm, crypto/bls12381, params: add bls12-381 elliptic curve precompiles (#21018) 2020-06-15 19:38:13 +03:00
analysis_test.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00
analysis.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00
common.go Use uint256 in EVM implementation (kudos to Pawel Bylica) (#551) 2020-05-18 08:10:59 +01:00
contract.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00
contracts_test.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
contracts.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
doc.go core/vm: remove JIT VM codes (#16362) 2018-03-26 13:48:04 +03:00
eips.go cmd/evm: add state transition tool for testing (#20958) 2020-08-07 11:38:07 +02:00
errors.go core/vm: EIP-2315, JUMPSUB for the EVM (#20619) 2020-06-15 19:38:13 +03:00
evm.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
evmc.go Use uint256 for account balance (#580) 2020-05-26 17:53:50 +01:00
gas_table_test.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00
gas_table.go core/vm: use uint256 in EVM implementation (#20787) 2020-08-07 11:04:19 +02:00
gas.go all: fix typos in comments (#21118) 2020-06-15 19:38:13 +03:00
gen_structlog.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
instructions_test.go core/vm: use uint256 in EVM implementation (#20787) 2020-08-07 11:04:19 +02:00
instructions.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
interface.go Use uint256 for account balance (#580) 2020-05-26 17:53:50 +01:00
interpreter.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
jump_table.go cmd, core, params: inital support for yolo-v1 testnet (#21154) 2020-06-15 19:38:13 +03:00
logger_json.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
logger_test.go core, eth, internal: include read storage entries in structlog output (#21204) 2020-08-07 11:17:27 +02:00
logger.go core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
memory_table.go stack pool (#627) 2020-06-05 17:45:56 +03:00
memory.go Use uint256 in EVM implementation (kudos to Pawel Bylica) (#551) 2020-05-18 08:10:59 +01:00
opcodes.go core/vm: EIP-2315, JUMPSUB for the EVM (#20619) 2020-06-15 19:38:13 +03:00
stack_table.go Apply Turbo-Geth modifications to go-ethereum codebase 2019-11-01 21:52:03 +01:00