erigon-pulse/eth
Martin Holst Swende a4b70f9ee9 core/vm: less allocations for various call variants (#21222)
* core/vm/runtime/tests: add more benchmarks

* core/vm: initial work on improving alloc count for calls to precompiles

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6     117ms ±75%      43ms ± 1%  -63.09%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   79.6ms ± 4%    70.5ms ± 1%  -11.42%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    24.4MB ± 0%     4.9MB ± 0%  -79.94%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 0%    13.2kB ± 0%     ~     (p=0.357 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6      382k ± 0%      153k ± 0%  -59.99%  (p=0.000 n=5+4)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* core/vm: don't allocate big.int for touch

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6    43.3ms ± 1%    42.4ms ± 7%     ~     (p=0.151 n=5+5)
SimpleLoop/loop-10M-6                   70.5ms ± 1%    76.7ms ± 1%   +8.67%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    4.90MB ± 0%    2.46MB ± 0%  -49.83%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 0%    13.2kB ± 1%     ~     (p=0.571 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6      153k ± 0%       76k ± 0%  -49.98%  (p=0.029 n=4+4)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* core/vm: reduce allocs in staticcall

name                                  old time/op    new time/op    delta
SimpleLoop/identity-precompile-10M-6    42.4ms ± 7%    37.5ms ± 6%  -11.68%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   76.7ms ± 1%    69.1ms ± 1%   -9.82%  (p=0.008 n=5+5)

name                                  old alloc/op   new alloc/op   delta
SimpleLoop/identity-precompile-10M-6    2.46MB ± 0%    0.02MB ± 0%  -99.35%  (p=0.008 n=5+5)
SimpleLoop/loop-10M-6                   13.2kB ± 1%    13.2kB ± 0%     ~     (p=0.143 n=5+5)

name                                  old allocs/op  new allocs/op  delta
SimpleLoop/identity-precompile-10M-6     76.4k ± 0%      0.1k ± 0%     ~     (p=0.079 n=4+5)
SimpleLoop/loop-10M-6                     40.0 ± 0%      40.0 ± 0%     ~     (all equal)

* trie: better use of hasher keccakState

* core/state/statedb: reduce allocations in getDeletedStateObject

* core/vm: reduce allocations in all call derivates

* core/vm: reduce allocations in call variants

- Make returnstack `uint32`
- Use a `sync.Pool` of `stack`s

* core/vm: fix tests

* core/vm: goimports

* core/vm: tracer fix + staticcall gas fix

* core/vm: add back snapshot to staticcall

* core/vm: review concerns + make returnstack pooled + enable returndata in traces

* core/vm: fix some test tracer method signatures

* core/vm: run gencodec, minor comment polish

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
# Conflicts:
#	core/state/statedb.go
#	core/vm/contracts_test.go
#	core/vm/evm.go
#	core/vm/instructions.go
#	core/vm/interpreter.go
#	core/vm/logger.go
#	core/vm/logger_json.go
#	core/vm/logger_test.go
#	core/vm/runtime/runtime_test.go
#	core/vm/stack/stack.go
#	eth/tracers/tracer.go
#	eth/tracers/tracer_test.go
#	trie/secure_trie.go
2020-08-07 13:46:26 +02:00
..
downloader les: historical data garbage collection (#19570) 2020-08-07 13:16:46 +02:00
fetcher remove eth/63, add tests for eth/65 (#823) 2020-07-30 11:16:55 +01:00
filters remove BoltDatabase, BadgerDatabase, RemoteDatabase classes (replaced by objectDb) (#794) 2020-07-27 22:59:54 +01:00
gasprice eth/gasprice: lighter gas price oracle for light client (#20409) 2020-08-07 12:29:19 +02:00
stagedsync Fix some snags in stage 6 2020-08-05 11:31:41 +01:00
tracers core/vm: less allocations for various call variants (#21222) 2020-08-07 13:46:26 +02:00
api_backend.go les: historical data garbage collection (#19570) 2020-08-07 13:16:46 +02:00
api_test.go Account range (#781) 2020-07-27 07:09:50 +01:00
api_tracer.go eth: returned revert reason in traceTx (#21195) 2020-08-07 11:23:14 +02:00
api.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00
backend.go Migrations: use stage name as db key (#868) 2020-08-05 17:13:35 +07:00
bloombits.go les: historical data garbage collection (#19570) 2020-08-07 13:16:46 +02:00
config.go les: historical data garbage collection (#19570) 2020-08-07 13:16:46 +02:00
debug.go Call bufio.Flash() in tester (#407) 2020-03-26 21:52:05 +00:00
discovery.go Make cmd/tester initiate staged sync, remove some pools and caches (#746) 2020-07-15 07:15:48 +01:00
firehose.go Parity only supports 3 letter capabilities 2020-01-07 16:34:44 +00:00
gen_config.go rpc, internal/ethapi: default rpc gascap at 25M + better error message (#21229) 2020-08-07 12:27:17 +02:00
handler_test.go eth: increase timeout in TestBroadcastBlock (#21299) 2020-08-07 12:49:19 +02:00
handler.go eth: don't block if transaction broadcast loop fails (#21255) 2020-08-07 11:22:09 +02:00
helper_test.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00
peer.go eth: don't block if transaction broadcast loop fails (#21255) 2020-08-07 11:22:09 +02:00
protocol_test.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00
protocol.go remove eth/63, add tests for eth/65 (#823) 2020-07-30 11:16:55 +01:00
sync_test.go remove eth/63, add tests for eth/65 (#823) 2020-07-30 11:16:55 +01:00
sync.go Jumpdest skip optimisation (#851) 2020-08-01 17:56:57 +01:00