From 5f3792c2a750dd95adeccbd5cf0cb19ecddfb43f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20Szil=C3=A1gyi?= Date: Mon, 29 Jun 2015 16:18:34 +0300 Subject: [PATCH] cmd/geth: decent error message if metrics are disabled --- cmd/geth/monitorcmd.go | 2 +- core/chain_manager.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/geth/monitorcmd.go b/cmd/geth/monitorcmd.go index 6a7e1cbb4..6593b3614 100644 --- a/cmd/geth/monitorcmd.go +++ b/cmd/geth/monitorcmd.go @@ -79,7 +79,7 @@ func monitor(ctx *cli.Context) { if len(list) > 0 { utils.Fatalf("No metrics specified.\n\nAvailable:\n - %s", strings.Join(list, "\n - ")) } else { - utils.Fatalf("No metrics specified.\n\nNo metrics collected (--metrics)\n") + utils.Fatalf("No metrics collected by geth (--%s).\n", utils.MetricsEnabledFlag.Name) } } sort.Strings(monitored) diff --git a/core/chain_manager.go b/core/chain_manager.go index 480311951..7c78b6bb7 100644 --- a/core/chain_manager.go +++ b/core/chain_manager.go @@ -23,7 +23,6 @@ import ( "github.com/ethereum/go-ethereum/pow" "github.com/ethereum/go-ethereum/rlp" "github.com/hashicorp/golang-lru" - "github.com/rcrowley/go-metrics" "github.com/syndtr/goleveldb/leveldb" )