mirror/lighthouse-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/lighthouse-pulse.git synced 2025-01-03 09:47:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Correct /lighthouse/nat implementation (#4069)

Browse Source 
## Proposed Changes

The current `/lighthouse/nat` implementation checks for _zero_ address updated messages, when it should check for a _non-zero_ number. This was spotted while debugging an issue on Discord where a user's ports weren't forwarded but `/lighthouse/nat` was still returning `true`.
This commit is contained in:
Michael Sproul 2023-03-13 04:08:15 +00:00
parent 373beaf913
commit 06af31a66a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
beacon_node/lighthouse_network/src/metrics.rs
View File

@ -159,7 +159,7 @@ pub fn check_nat() {
if NAT_OPEN.as_ref().map(|v| v.get()).unwrap_or(0) != 0 { if NAT_OPEN.as_ref().map(|v| v.get()).unwrap_or(0) != 0 {
return; return;
} }
if ADDRESS_UPDATE_COUNT.as_ref().map(|v| v.get()).unwrap_or(0) == 0 if ADDRESS_UPDATE_COUNT.as_ref().map(|v| v.get()).unwrap_or(0) != 0
|| NETWORK_INBOUND_PEERS.as_ref().map(|v| v.get()).unwrap_or(0) != 0_i64 || NETWORK_INBOUND_PEERS.as_ref().map(|v| v.get()).unwrap_or(0) != 0_i64
{ {
inc_counter(&NAT_OPEN); inc_counter(&NAT_OPEN);