mirror/lighthouse-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/lighthouse-pulse.git synced 2025-01-12 14:00:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

v0.6: remove some FIXMEs

Browse Source
This commit is contained in:
Michael Sproul 2019-06-17 16:02:01 +10:00
parent 8c5964a758
commit 1823378bfa
No known key found for this signature in database
GPG Key ID: 77B1309D2E54E914
3 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
eth2/types/src/beacon_state.rs
View File

@ -450,10 +450,10 @@ impl<T: EthSpec> BeaconState<T> {
Ok(&self.latest_block_roots[i]) Ok(&self.latest_block_roots[i])
} }
/// Return the block root at a recent `slot`. /// Return the block root at a recent `epoch`.
/// ///
/// Spec v0.6.0 /// Spec v0.6.0
// FIXME(sproul): name swap with get_block_root // NOTE: the spec calls this get_block_root
pub fn get_block_root_at_epoch(&self, epoch: Epoch) -> Result<&Hash256, BeaconStateError> { pub fn get_block_root_at_epoch(&self, epoch: Epoch) -> Result<&Hash256, BeaconStateError> {
self.get_block_root(epoch.start_slot(T::slots_per_epoch())) self.get_block_root(epoch.start_slot(T::slots_per_epoch()))
} }
@ -854,8 +854,6 @@ impl<T: EthSpec> BeaconState<T> {
self.committee_caches[Self::cache_index(relative_epoch)] = CommitteeCache::default(); self.committee_caches[Self::cache_index(relative_epoch)] = CommitteeCache::default();
} }
// FIXME(sproul): drop_previous/current_committee_cache
/// Updates the pubkey cache, if required. /// Updates the pubkey cache, if required.
/// ///
/// Adds all `pubkeys` from the `validator_registry` which are not already in the cache. Will /// Adds all `pubkeys` from the `validator_registry` which are not already in the cache. Will

2
eth2/types/src/test_utils/builders/testing_beacon_state_builder.rs
View File

@ -175,7 +175,7 @@ impl<T: EthSpec> TestingBeaconStateBuilder<T> {
state.slot = slot; state.slot = slot;
// FIXME(sproul): update latest_start_shard? // NOTE: we could update the latest start shard here
state.previous_justified_epoch = epoch - 3; state.previous_justified_epoch = epoch - 3;
state.current_justified_epoch = epoch - 2; state.current_justified_epoch = epoch - 2;

10
eth2/types/src/test_utils/builders/testing_pending_attestation_builder.rs
View File

@ -23,12 +23,18 @@ impl TestingPendingAttestationBuilder {
) -> Self { ) -> Self {
let data_builder = TestingAttestationDataBuilder::new(state, shard, slot, spec); let data_builder = TestingAttestationDataBuilder::new(state, shard, slot, spec);
let relative_epoch =
RelativeEpoch::from_epoch(state.current_epoch(), slot.epoch(T::slots_per_epoch()))
.expect("epoch out of bounds");
let proposer_index = state
.get_beacon_proposer_index(slot, relative_epoch, spec)
.unwrap() as u64;
let pending_attestation = PendingAttestation { let pending_attestation = PendingAttestation {
aggregation_bitfield: Bitfield::new(), aggregation_bitfield: Bitfield::new(),
data: data_builder.build(), data: data_builder.build(),
inclusion_delay: spec.min_attestation_inclusion_delay, inclusion_delay: spec.min_attestation_inclusion_delay,
// FIXME(sproul) proposer_index,
proposer_index: 0,
}; };
Self { Self {