mirror/lighthouse-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/lighthouse-pulse.git synced 2024-12-26 05:27:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix off-by-one in block packing lcli (#2878)

Browse Source 
## Issue Addressed

The current `lcli` block packing code has an off-by-one where it would include an extra slot (the oldest slot) of attestations as "available" (this means there would be 33 slots of "available" attestations instead of 32).
There is typically only single-digit attestations remaining from that slot and as such does not cause a significant change to the results although every efficiency will have been very slightly under-reported.

## Proposed Changes

Prune the `available_attestation_set` before writing out the data instead of after.

## Additional Info

This `lcli` code will soon be deprecated by a Lighthouse API (#2879)  which will run significantly faster and will be used to hook into our upcoming monitoring platform #2873.
This commit is contained in:
Mac L 2022-01-07 05:32:29 +00:00
parent 668477872e
commit 20941bc0f7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lcli/src/etl/block_efficiency.rs
View File

@ -274,6 +274,9 @@ pub async fn run<T: EthSpec>(matches: &ArgMatches<'_>) -> Result<(), String> {
// Add them to the set. // Add them to the set.
included_attestations_set.extend(attestations_in_block.clone()); included_attestations_set.extend(attestations_in_block.clone());
// Remove expired available attestations.
available_attestations_set.retain(|x| x.slot >= (slot.as_u64().saturating_sub(32)));
// Don't write data from the initialization epoch. // Don't write data from the initialization epoch.
if epoch != initialization_epoch { if epoch != initialization_epoch {
let included = attestations_in_block.len(); let included = attestations_in_block.len();
@ -309,9 +312,6 @@ pub async fn run<T: EthSpec>(matches: &ArgMatches<'_>) -> Result<(), String> {
} }
} }
} }
// Remove expired available attestations.
available_attestations_set.retain(|x| x.slot >= (slot.as_u64().saturating_sub(32)));
} }
let mut offline = "None".to_string(); let mut offline = "None".to_string();