mirror/lighthouse-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/lighthouse-pulse.git synced 2024-12-22 11:41:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix proposer cache miss in blob verification (#4646)

Browse Source
This commit is contained in:
Jimmy Chen 2023-08-22 08:35:49 +10:00 committed by GitHub
parent 63b876b87e
commit 49d7fdfed1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
beacon_node/beacon_chain/src/blob_verification.rs
View File

@ -187,6 +187,7 @@ pub fn validate_blob_sidecar_for_gossip<T: BeaconChainTypes>(
let block_parent_root = signed_blob_sidecar.message.block_parent_root; let block_parent_root = signed_blob_sidecar.message.block_parent_root;
let blob_proposer_index = signed_blob_sidecar.message.proposer_index; let blob_proposer_index = signed_blob_sidecar.message.proposer_index;
let block_root = signed_blob_sidecar.message.block_root; let block_root = signed_blob_sidecar.message.block_root;
let blob_epoch = blob_slot.epoch(T::EthSpec::slots_per_epoch());
// Verify that the blob_sidecar was received on the correct subnet. // Verify that the blob_sidecar was received on the correct subnet.
if blob_index != subnet { if blob_index != subnet {
@ -237,26 +238,32 @@ pub fn validate_blob_sidecar_for_gossip<T: BeaconChainTypes>(
// We have already verified that the blob is past finalization, so we can // We have already verified that the blob is past finalization, so we can
// just check fork choice for the block's parent. // just check fork choice for the block's parent.
if let Some(parent_block) = chain let Some(parent_block) = chain
.canonical_head .canonical_head
.fork_choice_read_lock() .fork_choice_read_lock()
.get_block(&block_parent_root) .get_block(&block_parent_root) else {
{
if parent_block.slot >= blob_slot {
return Err(GossipBlobError::BlobIsNotLaterThanParent {
blob_slot,
parent_slot: parent_block.slot,
});
}
} else {
return Err(GossipBlobError::BlobParentUnknown( return Err(GossipBlobError::BlobParentUnknown(
signed_blob_sidecar.message, signed_blob_sidecar.message,
)); ));
};
if parent_block.slot >= blob_slot {
return Err(GossipBlobError::BlobIsNotLaterThanParent {
blob_slot,
parent_slot: parent_block.slot,
});
} }
// Note: We check that the proposer_index matches against the shuffling first to avoid // Note: We check that the proposer_index matches against the shuffling first to avoid
// signature verification against an invalid proposer_index. // signature verification against an invalid proposer_index.
let proposer_shuffling_root = signed_blob_sidecar.message.block_parent_root; let proposer_shuffling_root =
if parent_block.slot.epoch(T::EthSpec::slots_per_epoch()) == blob_epoch {
parent_block
.next_epoch_shuffling_id
.shuffling_decision_block
} else {
parent_block.root
};
let proposer_opt = chain let proposer_opt = chain
.beacon_proposer_cache .beacon_proposer_cache
@ -349,7 +356,7 @@ pub fn validate_blob_sidecar_for_gossip<T: BeaconChainTypes>(
// Prime the proposer shuffling cache with the newly-learned value. // Prime the proposer shuffling cache with the newly-learned value.
chain.beacon_proposer_cache.lock().insert( chain.beacon_proposer_cache.lock().insert(
blob_slot.epoch(T::EthSpec::slots_per_epoch()), blob_epoch,
proposer_shuffling_root, proposer_shuffling_root,
proposers, proposers,
state.fork(), state.fork(),