diff --git a/beacon_node/execution_layer/src/lib.rs b/beacon_node/execution_layer/src/lib.rs index f56ea8f79..e7bbc6cd5 100644 --- a/beacon_node/execution_layer/src/lib.rs +++ b/beacon_node/execution_layer/src/lib.rs @@ -1267,14 +1267,6 @@ impl ExecutionLayer { } /// Maps to the `eth_getBlockByHash` JSON-RPC call. - /// - /// ## TODO(merge) - /// - /// This will return an execution block regardless of whether or not it was created by a PoW - /// miner (pre-merge) or a PoS validator (post-merge). It's not immediately clear if this is - /// correct or not, see the discussion here: - /// - /// https://github.com/ethereum/consensus-specs/issues/2636 async fn get_pow_block( &self, engine: &Engine, diff --git a/beacon_node/network/src/beacon_processor/worker/gossip_methods.rs b/beacon_node/network/src/beacon_processor/worker/gossip_methods.rs index 12172e0e5..e6625e43f 100644 --- a/beacon_node/network/src/beacon_processor/worker/gossip_methods.rs +++ b/beacon_node/network/src/beacon_processor/worker/gossip_methods.rs @@ -771,12 +771,15 @@ impl Worker { debug!(self.log, "Could not verify block for gossip, ignoring the block"; "error" => %e); // Prevent recurring behaviour by penalizing the peer slightly. - self.gossip_penalize_peer(peer_id, PeerAction::HighToleranceError, "gossip_block_high"); + self.gossip_penalize_peer( + peer_id, + PeerAction::HighToleranceError, + "gossip_block_high", + ); self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore); return None; } - // TODO(merge): reconsider peer scoring for this event. - Err(ref e @BlockError::ExecutionPayloadError(ref epe)) if !epe.penalize_peer() => { + Err(ref e @ BlockError::ExecutionPayloadError(ref epe)) if !epe.penalize_peer() => { debug!(self.log, "Could not verify block for gossip, ignoring the block"; "error" => %e); self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Ignore); @@ -795,7 +798,6 @@ impl Worker { | Err(e @ BlockError::TooManySkippedSlots { .. }) | Err(e @ BlockError::WeakSubjectivityConflict) | Err(e @ BlockError::InconsistentFork(_)) - // TODO(merge): reconsider peer scoring for this event. | Err(e @ BlockError::ExecutionPayloadError(_)) // TODO(merge): reconsider peer scoring for this event. | Err(e @ BlockError::ParentExecutionPayloadInvalid { .. }) @@ -803,7 +805,11 @@ impl Worker { warn!(self.log, "Could not verify block for gossip, rejecting the block"; "error" => %e); self.propagate_validation_result(message_id, peer_id, MessageAcceptance::Reject); - self.gossip_penalize_peer(peer_id, PeerAction::LowToleranceError, "gossip_block_low"); + self.gossip_penalize_peer( + peer_id, + PeerAction::LowToleranceError, + "gossip_block_low", + ); return None; } }; diff --git a/consensus/proto_array/src/proto_array_fork_choice.rs b/consensus/proto_array/src/proto_array_fork_choice.rs index 306c98601..9902ccb1c 100644 --- a/consensus/proto_array/src/proto_array_fork_choice.rs +++ b/consensus/proto_array/src/proto_array_fork_choice.rs @@ -38,7 +38,7 @@ pub enum ExecutionStatus { /// /// This `bool` only exists to satisfy our SSZ implementation which requires all variants /// to have a value. It can be set to anything. - Irrelevant(bool), // TODO(merge): fix bool. + Irrelevant(bool), } impl ExecutionStatus {