mirror/lighthouse-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/lighthouse-pulse.git synced 2024-12-22 03:30:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix proposer reward calculations

Browse Source 
Aggregate the value before applying the balance increase as done
in Prysm. The previous incremental additions resulted in different
reward burn behavior because of truncation in the math.
This commit is contained in:
Shane Bammel 2023-02-03 16:39:11 -06:00
parent 05feeaec2a
commit a7adb9c813
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
consensus/state_processing/src/per_block_processing/altair/sync_committee.rs
View File

@ -47,18 +47,19 @@ pub fn process_sync_aggregate<T: EthSpec>(
// Apply participant and proposer rewards // Apply participant and proposer rewards
let committee_indices = state.get_sync_committee_indices(&current_sync_committee)?; let committee_indices = state.get_sync_committee_indices(&current_sync_committee)?;
let mut earned_proposer_reward = 0;
for (participant_index, participation_bit) in committee_indices for (participant_index, participation_bit) in committee_indices
.into_iter() .into_iter()
.zip(aggregate.sync_committee_bits.iter()) .zip(aggregate.sync_committee_bits.iter())
{ {
if participation_bit { if participation_bit {
increase_balance(state, participant_index, participant_reward, spec, true)?; increase_balance(state, participant_index, participant_reward, spec, true)?;
increase_balance(state, proposer_index as usize, proposer_reward, spec, true)?; earned_proposer_reward += proposer_reward;
} else { } else {
decrease_balance(state, participant_index, participant_reward)?; decrease_balance(state, participant_index, participant_reward)?;
} }
} }
increase_balance(state, proposer_index as usize, earned_proposer_reward, spec, true)?;
Ok(()) Ok(())
} }