Go to file
João Oliveira 0dc95a1d37 PeerManager: move the check for banned peers from connection_established (#4569)
## Issue Addressed
https://github.com/sigp/lighthouse/issues/4543
## Proposed Changes
- Removes `NotBanned` from `BanResult`, implements `Display` and `std::error::Error` for `BanResult` and changes `ban_result` return type to `Option<BanResult>` which helps returning `BanResult` on `handle_established_inbound_connection`  
- moves the check from for banned peers from `on_connection_established` to `handle_established_inbound_connection` to start addressing #4543.
- Removes `allow_block_list` as it's now redundant? Not sure about this one but if `PeerManager` keeps track of the banned peers, no need to send a `Swarm` event for `alow_block_list` to also keep that list right? 
 
## Questions

-  #4543 refers:
>  More specifically, implement the connection limit behaviour inside the peer manager.

@AgeManning do you mean copying `libp2p::connection_limits::Behaviour`'s code into `PeerManager`/ having it as an inner `NetworkBehaviour` of `PeerManager`/other? If it's the first two, I think it probably makes more sense to have it as it is as it's less code to maintain.

> Also implement the banning of peers inside the behaviour, rather than passing messages back up to the swarm.

I tried to achieve this, but we still need to pass the `PeerManagerEvent::Banned` swarm event as `DiscV5` handles it's node and ip management internally and I did not find a method to query if a peer is banned. Is there anything else we can do from here?

3397612160/beacon_node/lighthouse_network/src/discovery/mod.rs (L931-L940)

Same as the question above, I did not find a way to check if `DiscV5` has the peer banned, so that we could check here and avoid sending `Swarm` events

3397612160/beacon_node/lighthouse_network/src/peer_manager/network_behaviour.rs (L168-L178)

Is there a chance we try to dial a peer that has been banned previously? 

Thanks!
2023-10-03 23:59:32 +00:00
.cargo Switch allocator to jemalloc (#3697) 2023-01-20 04:19:29 +00:00
.config Ultra Fast Super Slick CI (#4755) 2023-10-03 06:33:15 +00:00
.github Ultra Fast Super Slick CI (#4755) 2023-10-03 06:33:15 +00:00
account_manager Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
beacon_node PeerManager: move the check for banned peers from connection_established (#4569) 2023-10-03 23:59:32 +00:00
book Update Java runtime requirement to 17 for Web3Signer tests (#4681) 2023-09-15 08:49:14 +00:00
boot_node Release v4.5.0 (#4768) 2023-09-25 05:14:01 +00:00
common Ultra Fast Super Slick CI (#4755) 2023-10-03 06:33:15 +00:00
consensus Use only lighthouse types in the mock builder (#4793) 2023-10-03 17:59:28 +00:00
crypto Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
database_manager Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
lcli Release v4.5.0 (#4768) 2023-09-25 05:14:01 +00:00
lighthouse Allow libp2p to determine listening addresses (#4700) 2023-10-03 04:57:20 +00:00
scripts Fix local testnet to generate keys in the correct folders (#4752) 2023-09-21 00:26:56 +00:00
slasher Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
testing Ultra Fast Super Slick CI (#4755) 2023-10-03 06:33:15 +00:00
validator_client Use only lighthouse types in the mock builder (#4793) 2023-10-03 17:59:28 +00:00
validator_manager Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
watch Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
.dockerignore Exclude EE build dirs from Docker context (#3174) 2022-05-09 23:43:31 +00:00
.editorconfig align editorconfig with rustfmt (#4600) 2023-08-14 00:29:44 +00:00
.gitignore Docs for Siren (#4023) 2023-02-28 02:20:52 +00:00
.gitmodules Replace EF tests submodule with a makefile 2019-09-08 04:19:54 +10:00
bors.toml Ultra Fast Super Slick CI (#4755) 2023-10-03 06:33:15 +00:00
Cargo.lock Use only lighthouse types in the mock builder (#4793) 2023-10-03 17:59:28 +00:00
Cargo.toml Use only lighthouse types in the mock builder (#4793) 2023-10-03 17:59:28 +00:00
CONTRIBUTING.md Add branching instructions to the contribution guide (#4272) 2023-05-08 12:20:19 +00:00
Cross.toml upgrade to libp2p 0.52 (#4431) 2023-08-02 00:59:34 +00:00
Dockerfile Fix genesis state download panic when running in debug mode (#4753) 2023-09-21 04:17:25 +00:00
Dockerfile.cross Use a stable tag for ubuntu in dockerfile (#3231) 2022-05-31 06:09:12 +00:00
LICENSE Update License to Apache 2.0 2019-04-15 16:47:35 +10:00
Makefile Ultra Fast Super Slick CI (#4755) 2023-10-03 06:33:15 +00:00
README.md Update blog link in README (#4322) 2023-05-30 01:38:47 +00:00
SECURITY.md Add how users should report security vulnerabilities for this repository (#2562) 2021-09-07 01:54:05 +00:00

Lighthouse: Ethereum consensus client

An open-source Ethereum consensus client, written in Rust and maintained by Sigma Prime.

Book Status Chat Badge

Documentation

Banner

Overview

Lighthouse is:

  • Ready for use on Ethereum consensus mainnet.
  • Fully open-source, licensed under Apache 2.0.
  • Security-focused. Fuzzing techniques have been continuously applied and several external security reviews have been performed.
  • Built in Rust, a modern language providing unique safety guarantees and excellent performance (comparable to C++).
  • Funded by various organisations, including Sigma Prime, the Ethereum Foundation, ConsenSys, the Decentralization Foundation and private individuals.
  • Actively involved in the specification and security analysis of the Ethereum proof-of-stake consensus specification.

Staking Deposit Contract

The Lighthouse team acknowledges 0x00000000219ab540356cBB839Cbe05303d7705Fa as the canonical staking deposit contract address.

Documentation

The Lighthouse Book contains information for users and developers.

The Lighthouse team maintains a blog at lighthouse-blog.sigmaprime.io which contains periodical progress updates, roadmap insights and interesting findings.

Branches

Lighthouse maintains two permanent branches:

  • stable: Always points to the latest stable release.
    • This is ideal for most users.
  • unstable: Used for development, contains the latest PRs.
    • Developers should base their PRs on this branch.

Contributing

Lighthouse welcomes contributors.

If you are looking to contribute, please head to the Contributing section of the Lighthouse book.

Contact

The best place for discussion is the Lighthouse Discord server.

Sign up to the Lighthouse Development Updates mailing list for email notifications about releases, network status and other important information.

Encrypt sensitive messages using our PGP key.

Donations

Lighthouse is an open-source project and a public good. Funding public goods is hard and we're grateful for the donations we receive from the community via:

  • Gitcoin Grants.
  • Ethereum address: 0x25c4a76E7d118705e7Ea2e9b7d8C59930d8aCD3b (donation.sigmaprime.eth).