mirror/lighthouse-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/lighthouse-pulse.git synced 2024-12-22 03:30:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
18f3edff0a
lighthouse-pulse/common
History
Jimmy Chen 64c156c0c1 Pre-generate test blobs bundle to improve test time. (#4829) 
## Issue Addressed

Addresses #4778, and potentially fixes the flaky deneb builder test `builder_works_post_deneb`.

The [deneb builder test](c5c84f1213/beacon_node/http_api/tests/tests.rs (L5371)) has been quite flaky on our CI (`release-tests`) since it was introduced. I'm guessing that it might be timing out on the builder `get_header` call (1 second), and therefore the local payload is used, while the test expects builder payload to be used. 

On my machine the [`get_header` ](c5c84f1213/beacon_node/execution_layer/src/test_utils/mock_builder.rs (L367)) call takes about 550ms, which could easily go over 1s on slower environments (our windows CI runner is much slower than the ubuntu one).

I did a profile on the test and it showed that `blob_to_kzg_commiment` and `compute_kzg_proof` was taking a large chunk of time, so perhaps pre-generating the blobs could help stablise this test.

## Proposed Changes

Pre-generate blobs bundle for Mainnet and Minimal presets.

Before the change `get_header` took about **550ms**, and it's now reduced to **50-55ms** after the change. If timeout was indeed the cause of the flaky test, this fix should stablise it. This also brings the flaky `builder_works_post_deneb` test time from 50s to 10s. (8s if we only use a single blob)
2023-10-18 04:40:29 +00:00
..
account_utils Remove serde derive references (#4830) 2023-10-11 13:01:30 -04:00
clap_utils Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
compare_fields Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
compare_fields_derive
deposit_contract Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
directory Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
eth2
eth2_config
eth2_interop_keypairs
eth2_network_config
eth2_wallet_manager
filesystem Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
lighthouse_metrics
lighthouse_version Release v4.5.0 (#4768) 2023-09-25 05:14:01 +00:00
lockfile
logging Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
lru_cache
malloc_utils
monitoring_api Remove serde derive references (#4830) 2023-10-11 13:01:30 -04:00
oneshot_broadcast
pretty_reqwest_error
sensitive_url
slot_clock Merge unstable 20230925 into deneb-free-blobs. 2023-09-26 10:32:18 +10:00
system_health
target_check
task_executor Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
test_random_derive
unused_port Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
validator_dir Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
warp_utils Move dependencies to workspace (#4650) 2023-09-22 04:30:56 +00:00
README.md

README.md

eth2

Common crates containing eth2-specific logic.