lighthouse-pulse/beacon_node
Paul Hauner 2de26b20f8 Don't return errors on HTTP API for already-known messages (#3341)
## Issue Addressed

- Resolves #3266

## Proposed Changes

Return 200 OK rather than an error when a block, attestation or sync message is already known.

Presently, we will log return an error which causes a BN to go "offline" from the VCs perspective which causes the fallback mechanism to do work to try and avoid and upcheck offline nodes. This can be observed as instability in the `vc_beacon_nodes_available_count` metric.

The current behaviour also causes scary logs for the user. There's nothing to *actually* be concerned about when we see duplicate messages, this can happen on fallback systems (see code comments).

## Additional Info

NA
2022-08-10 07:52:57 +00:00
..
beacon_chain Don't use the builder network if the head is optimistic (#3412) 2022-08-09 06:05:16 +00:00
builder_client Builder Specs v0.2.0 (#3134) 2022-07-30 00:22:37 +00:00
client Tidy eth1/deposit contract logging (#3397) 2022-08-01 07:20:43 +00:00
eth1 Tidy eth1/deposit contract logging (#3397) 2022-08-01 07:20:43 +00:00
execution_layer Don't use the builder network if the head is optimistic (#3412) 2022-08-09 06:05:16 +00:00
genesis Unify execution layer endpoints (#3214) 2022-06-29 09:07:09 +00:00
http_api Don't return errors on HTTP API for already-known messages (#3341) 2022-08-10 07:52:57 +00:00
http_metrics Support IPv6 in BN and VC HTTP APIs (#3104) 2022-03-24 00:04:49 +00:00
lighthouse_network Return ResourceUnavailable if we are unable to reconstruct execution payloads (#3365) 2022-07-27 03:20:00 +00:00
network Fix penalties in sync methods (#3384) 2022-07-30 00:22:39 +00:00
operation_pool Use async code when interacting with EL (#3244) 2022-07-03 05:36:50 +00:00
src Fix a few typos in option help strings (#3401) 2022-08-02 00:58:24 +00:00
store Initial Commit of Retrospective OTB Verification (#3372) 2022-07-30 00:22:38 +00:00
tests Altair consensus changes and refactors (#2279) 2021-07-09 06:15:32 +00:00
timer Use async code when interacting with EL (#3244) 2022-07-03 05:36:50 +00:00
Cargo.toml Release v2.5.1 (#3406) 2022-08-03 04:23:09 +00:00