Paul Hauner d23437f726 Ensure FC uses the current slot from the store (#3402) ... ## Issue Addressed NA ## Proposed Changes Ensure that we read the current slot from the `fc_store` rather than the slot clock. This is because the `fc_store` will never allow the slot to go backwards, even if the system clock does. The `ProtoArray::find_head` function assumes a non-decreasing slot. This issue can cause logs like this: ``` ERRO Error whist recomputing head, error: ForkChoiceError(ProtoArrayError("find_head failed: InvalidBestNode(InvalidBestNodeInfo { start_root: 0xb22655aa2ae23075a60bd40797b3ba220db33d6fb86fa7910f0ed48e34bda72f, justified_checkpoint: Checkpoint { epoch: Epoch(111569), root: 0xb22655aa2ae23075a60bd40797b3ba220db33d6fb86fa7910f0ed48e34bda72f }, finalized_checkpoint: Checkpoint { epoch: Epoch(111568), root: 0x6140797e40c587b0d3f159483bbc603accb7b3af69891979d63efac437f9896f }, head_root: 0xb22655aa2ae23075a60bd40797b3ba220db33d6fb86fa7910f0ed48e34bda72f, head_justified_checkpoint: Some(Checkpoint { epoch: Epoch(111568), root: 0x6140797e40c587b0d3f159483bbc603accb7b3af69891979d63efac437f9896f }), head_finalized_checkpoint: Some(Checkpoint { epoch: Epoch(111567), root: 0x59b913d37383a158a9ea5546a572acc79e2cdfbc904c744744789d2c3814c570 }) })")), service: beacon, module: beacon_chain::canonical_head:499 ``` We expect nodes to automatically recover from this issue within seconds without any major impact. However, having *any* errors in the path of fork choice is undesirable and should be avoided. ## Additional Info NA		2022-08-02 00:58:25 +00:00
..
fork_choice_test_definition	Retrospective invalidation of exec. payloads for opt. sync (#2837)	2022-02-28 22:07:48 +00:00
bin.rs	Retrospective invalidation of exec. payloads for opt. sync (#2837)	2022-02-28 22:07:48 +00:00
error.rs	Ensure FC uses the current slot from the store (#3402)	2022-08-02 00:58:25 +00:00
fork_choice_test_definition.rs	Remove equivocating validators from fork choice (#3371)	2022-07-28 09:43:41 +00:00
lib.rs	Rename random to prev_randao (#3040)	2022-03-03 02:10:57 +00:00
proto_array_fork_choice.rs	Indicate that invalid blocks are optimistic (#3383)	2022-07-30 05:08:57 +00:00
proto_array.rs	Ensure FC uses the current slot from the store (#3402)	2022-08-02 00:58:25 +00:00
ssz_container.rs	v1.1.6 Fork Choice changes (#2822)	2021-12-13 20:43:22 +00:00