Michael Sproul 77eabc5401 Revert "Optimise HTTP validator lookups" (#3658) ... ## Issue Addressed This reverts commit ca9dc8e094 (PR #3559) with some modifications. ## Proposed Changes Unfortunately that PR introduced a performance regression in fork choice. The optimisation _intended_ to build the exit and pubkey caches on the head state _only if_ they were not already built. However, due to the head state always being cloned without these caches, we ended up building them every time the head changed, leading to a ~70ms+ penalty on mainnet. fcfd02aeec/beacon_node/beacon_chain/src/canonical_head.rs (L633-L636) I believe this is a severe enough regression to justify immediately releasing v3.2.1 with this change. ## Additional Info I didn't fully revert #3559, because there were some unrelated deletions of dead code in that PR which I figured we may as well keep. An alternative would be to clone the extra caches, but this likely still imposes some cost, so in the interest of applying a conservative fix quickly, I think reversion is the best approach. The optimisation from #3559 was not even optimising a particularly significant path, it was mostly for VCs running larger numbers of inactive keys. We can re-do it in the `tree-states` world where cache clones are cheap.		2022-10-26 06:50:04 +00:00
..
src	Revert "Optimise HTTP validator lookups" (#3658)	2022-10-26 06:50:04 +00:00
tests	Remove fallback support from eth1 service (#3594)	2022-10-04 08:33:39 +00:00
Cargo.toml	Builder Specs v0.2.0 (#3134)	2022-07-30 00:22:37 +00:00