mirror/lighthouse-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/lighthouse-pulse.git synced 2024-12-24 12:37:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
3,601 Commits 2 Branches 16 Tags 112 MiB
Rust 99.5%
Shell 0.2%
Makefile 0.1%
a17f74896a
Go to file
Paul Hauner a17f74896a Fix bad assumption when checking finalized descendant (#1629) 
## Issue Addressed

- Resolves #1616

## Proposed Changes

Fixes a bug where we are unable to read the finalized block from fork choice.

## Detail

I had made an assumption that the finalized block always has a parent root of `None`:

e5fc6bab48/consensus/fork_choice/src/fork_choice.rs (L749-L752)

This was a faulty assumption, we don't set parent *roots* to `None`. Instead we *sometimes* set parent *indices* to `None`, depending if this pruning condition is satisfied: 

e5fc6bab48/consensus/proto_array/src/proto_array.rs (L229-L232) 

The bug manifested itself like this:

1. We attempt to get the finalized block from fork choice
1. We try to check that the block is descendant of the finalized block (note: they're the same block).
1. We expect the parent root to be `None`, but it's actually the parent root of the finalized root.
1. We therefore end up checking if the parent of the finalized root is a descendant of itself. (note: it's an *ancestor* not a *descendant*).
1. We therefore declare that the finalized block is not a descendant of (or eq to) the finalized block. Bad.

## Additional Info

In reflection, I made a poor assumption in the quest to obtain a probably negligible performance gain. The performance gain wasn't worth the risk and we got burnt.
2020-09-18 05:14:31 +00:00
.github Revert "add a github action for build multi-arch docker images (#1574)" (#1591) 2020-09-06 04:46:25 +00:00
account_manager Bump version to v0.2.9 (#1598) 2020-09-09 02:28:35 +00:00
beacon_node Fix bad assumption when checking finalized descendant (#1629) 2020-09-18 05:14:31 +00:00
book Remove references to rust-docs (#1601) 2020-09-10 00:24:41 +00:00
boot_node Bump version to v0.2.9 (#1598) 2020-09-09 02:28:35 +00:00
common Static testnet configs (#1603) 2020-09-11 01:43:13 +00:00
consensus Fix bad assumption when checking finalized descendant (#1629) 2020-09-18 05:14:31 +00:00
crypto Mnemonic key recovery (#1579) 2020-09-08 12:17:51 +00:00
hooks Add a flag to make lighthouse portable across machines (#1423) 2020-07-31 05:00:39 +00:00
lcli Bump version to v0.2.9 (#1598) 2020-09-09 02:28:35 +00:00
lighthouse Bump version to v0.2.9 (#1598) 2020-09-09 02:28:35 +00:00
scripts Bump to v0.2.7 (#1561) 2020-08-24 08:25:34 +00:00
testing Eth1 network exit on wrong network id (#1563) 2020-08-31 02:36:17 +00:00
validator_client Bump version to v0.2.9 (#1598) 2020-09-09 02:28:35 +00:00
.dockerignore Ensure .git is copied into docker (#1462) 2020-08-05 03:05:36 +00:00
.editorconfig Add editorconfig template 2019-03-11 15:09:57 +11:00
.gitignore Commit Cargo.lock changes, add build scripts (#1521) 2020-08-14 22:24:27 +00:00
.gitmodules Replace EF tests submodule with a makefile 2019-09-08 04:19:54 +10:00
bors.toml Fix bors timeouts (#1341) 2020-07-07 13:44:35 +00:00
Cargo.lock Static testnet configs (#1603) 2020-09-11 01:43:13 +00:00
Cargo.toml Add serde_utils module with quoted u64 support (#1588) 2020-09-07 01:03:53 +00:00
CONTRIBUTING.md Update CONTRIBUTING.md (#751) 2020-01-03 10:45:53 +11:00
Cross.toml Ensure RUSTFLAGS is passed through on cross compile (#1529) 2020-08-17 10:06:06 +00:00
Dockerfile Revert 1502 - Switching docker user to lighthouse (#1578) 2020-09-01 01:32:02 +00:00
LICENSE Update License to Apache 2.0 2019-04-15 16:47:35 +10:00
Makefile Commit Cargo.lock changes, add build scripts (#1521) 2020-08-14 22:24:27 +00:00
README.md Remove references to rust-docs (#1601) 2020-09-10 00:24:41 +00:00

README.md

Lighthouse: Ethereum 2.0

An open-source Ethereum 2.0 client, written in Rust and maintained by Sigma Prime.

Build Status Book Status Chat Badge

Documentation

terminalize

Overview

Lighthouse is:

  • Fully open-source, licensed under Apache 2.0.
  • Security-focused. Fuzzing has begun and security reviews are underway.
  • Built in Rust, a modern language providing unique safety guarantees and excellent performance (comparable to C++).
  • Funded by various organisations, including Sigma Prime, the Ethereum Foundation, ConsenSys and private individuals.
  • Actively involved in the specification and security analysis of the emerging Ethereum 2.0 specification.

Like all Ethereum 2.0 clients, Lighthouse is a work-in-progress.

Development Status

Current development overview:

  • Specification v0.12.1 implemented, optimized and passing test vectors.
  • Rust-native libp2p with Gossipsub and Discv5.
  • RESTful JSON API via HTTP server.
  • Events via WebSocket.
  • Metrics via Prometheus.

Roadmap

  • April 2019: Inital single-client testnets.
  • September 2019: Inter-operability with other Ethereum 2.0 clients.
  • Q1 2020: lighthouse-0.1.0 release: All major phase 0 features implemented.
  • Q2 2020: Public, multi-client testnet with user-facing functionality.
  • Q2 2020: Third-party security review.
  • Q3 2020: Additional third-party security reviews.
  • Q3 2020: Long-lived, multi-client Beacon Chain testnet
  • Q4 2020: Production Beacon Chain (tentative).

Documentation

The Lighthouse Book contains information for testnet users and developers.

If you'd like some background on Sigma Prime, please see the Lighthouse Update #00 blog post or sigmaprime.io.

Contributing

Lighthouse welcomes contributors.

If you are looking to contribute, please head to the Contributing section of the Lighthouse book.

Contact

The best place for discussion is the Lighthouse Discord server. Alternatively, you may use the sigp/lighthouse gitter.

Encrypt sensitive messages using our PGP key.

Donations

Lighthouse is an open-source project and a public good. Funding public goods is hard and we're grateful for the donations we receive from the community via:

  • Gitcoin Grants.
  • Ethereum address: 0x25c4a76E7d118705e7Ea2e9b7d8C59930d8aCD3b (donation.sigmaprime.eth).