lighthouse-pulse/.github
Michael Sproul 1d016a83f2 Lint against panicky calls in async functions (#3250)
## Description

Add a new lint to CI that attempts to detect calls to functions like `block_on` from async execution contexts. This lint was written from scratch exactly for this purpose, on my fork of Clippy: https://github.com/michaelsproul/rust-clippy/tree/disallow-from-async

## Additional Info

- I've successfully detected the previous two issues we had with `block_on` by running the linter on the commits prior to each of these PRs: https://github.com/sigp/lighthouse/pull/3165, https://github.com/sigp/lighthouse/pull/3199.
- The lint runs on CI with `continue-on-error: true` so that if it fails spuriously it won't block CI.
- I think it would be good to merge this PR before https://github.com/sigp/lighthouse/pull/3244 so that we can lint the extensive executor-related changes in that PR.
- I aim to upstream the lint to Clippy, at which point building a custom version of Clippy from my fork will no longer be necessary. I imagine this will take several weeks or months though, because the code is currently a bit hacky and will need some renovations to pass review.
2022-06-10 04:29:27 +00:00
..
custom Lint against panicky calls in async functions (#3250) 2022-06-10 04:29:27 +00:00
workflows Lint against panicky calls in async functions (#3250) 2022-06-10 04:29:27 +00:00
ISSUE_TEMPLATE.md Remove links to old master branch (#2190) 2021-02-11 06:06:54 +00:00
PULL_REQUEST_TEMPLATE.md Add PR and issue templates 2018-10-14 14:51:59 +11:00