Mac L 80627b428b Fix linting error on Windows (#2759) ... While testing some code on Windows, I ran into a failure when using `clippy` via (`make lint`): ``` error: this expression borrows a reference (`&str`) that is immediately dereferenced by the compiler --> common/filesystem/src/lib.rs:105:43 | 105 | let mut acl = ACL::from_file_path(&path_str, false).map_err(Error::UnableToRetrieveACL)?; | ^^^^^^^^^ help: change this to: `path_str` | = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow error: could not compile `filesystem` due to previous error ``` ## Proposed Changes Remove the unnecessary borrow as suggested. ## Additional Info Since we are only running `clippy` in CI on Ubuntu, I believe we don't have any way (in CI) to detect these Windows specific lint errors (either from new code, or from linting changes from new Rust versions. This is because code marked as `#[cfg(windows)]` is not checked on `unix` systems and vice versa. I'm conscious that our CI runs are already taking a long time, and that adding a new Windows `clippy` run would add a non-negligible amount of time to the runs (not sure if this topic has already been discussed), but it something to be aware of. ## Extra Note I don't think this is the case, but it might be worth someone else running `make lint` on their Windows machines to eliminate the possibility that this is an error specific to my setup.		2021-11-01 07:44:42 +00:00
..
src	Fix linting error on Windows (#2759)	2021-11-01 07:44:42 +00:00
Cargo.toml	Enable Compatibility with Windows (#2333)	2021-05-19 23:05:16 +00:00