coresight: tmc: Enable panic sync handling

- Get reserved region from device tree node for metadata
- Define metadata format for TMC
- Add TMC ETR panic sync handler that syncs register snapshot
  to metadata region
- Add TMC ETF panic sync handler that syncs register snapshot
  to metadata region and internal SRAM to reserved trace buffer
  region.

Signed-off-by: Linu Cherian <lcherian@marvell.com>
Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20250212114918.548431-5-lcherian@marvell.com
This commit is contained in:
Linu Cherian 2025-02-12 17:19:14 +05:30 committed by Suzuki K Poulose
parent 46006ceb5d
commit 6dbcbcfc44
4 changed files with 233 additions and 0 deletions

View File

@ -444,6 +444,20 @@ static void tmc_get_reserved_region(struct device *parent)
drvdata->resrv_buf.paddr = res.start;
drvdata->resrv_buf.size = resource_size(&res);
if (of_tmc_get_reserved_resource_by_name(parent, "metadata", &res))
return;
drvdata->crash_mdata.vaddr = memremap(res.start,
resource_size(&res),
MEMREMAP_WC);
if (IS_ERR_OR_NULL(drvdata->crash_mdata.vaddr)) {
dev_err(parent, "Metadata memory mapping failed\n");
return;
}
drvdata->crash_mdata.paddr = res.start;
drvdata->crash_mdata.size = resource_size(&res);
}
/* Detect and initialise the capabilities of a TMC ETR */

View File

@ -590,6 +590,81 @@ out:
return to_read;
}
static int tmc_panic_sync_etf(struct coresight_device *csdev)
{
u32 val;
struct tmc_crash_metadata *mdata;
struct tmc_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
mdata = (struct tmc_crash_metadata *)drvdata->crash_mdata.vaddr;
/* Make sure we have valid reserved memory */
if (!tmc_has_reserved_buffer(drvdata) ||
!tmc_has_crash_mdata_buffer(drvdata))
return 0;
tmc_crashdata_set_invalid(drvdata);
CS_UNLOCK(drvdata->base);
/* Proceed only if ETF is enabled or configured as sink */
val = readl(drvdata->base + TMC_CTL);
if (!(val & TMC_CTL_CAPT_EN))
goto out;
val = readl(drvdata->base + TMC_MODE);
if (val != TMC_MODE_CIRCULAR_BUFFER)
goto out;
val = readl(drvdata->base + TMC_FFSR);
/* Do manual flush and stop only if its not auto-stopped */
if (!(val & TMC_FFSR_FT_STOPPED)) {
dev_dbg(&csdev->dev,
"%s: Triggering manual flush\n", __func__);
tmc_flush_and_stop(drvdata);
} else
tmc_wait_for_tmcready(drvdata);
/* Sync registers from hardware to metadata region */
mdata->tmc_sts = readl(drvdata->base + TMC_STS);
mdata->tmc_mode = readl(drvdata->base + TMC_MODE);
mdata->tmc_ffcr = readl(drvdata->base + TMC_FFCR);
mdata->tmc_ffsr = readl(drvdata->base + TMC_FFSR);
/* Sync Internal SRAM to reserved trace buffer region */
drvdata->buf = drvdata->resrv_buf.vaddr;
tmc_etb_dump_hw(drvdata);
/* Store as per RSZ register convention */
mdata->tmc_ram_size = drvdata->len >> 2;
/* Other fields for processing trace buffer reads */
mdata->tmc_rrp = 0;
mdata->tmc_dba = 0;
mdata->tmc_rwp = drvdata->len;
mdata->trace_paddr = drvdata->resrv_buf.paddr;
mdata->version = CS_CRASHDATA_VERSION;
/*
* Make sure all previous writes are ordered,
* before we mark valid
*/
dmb(sy);
mdata->valid = true;
/*
* Below order need to maintained, since crc of metadata
* is dependent on first
*/
mdata->crc32_tdata = find_crash_tracedata_crc(drvdata, mdata);
mdata->crc32_mdata = find_crash_metadata_crc(mdata);
tmc_disable_hw(drvdata);
dev_dbg(&csdev->dev, "%s: success\n", __func__);
out:
CS_UNLOCK(drvdata->base);
return 0;
}
static const struct coresight_ops_sink tmc_etf_sink_ops = {
.enable = tmc_enable_etf_sink,
.disable = tmc_disable_etf_sink,
@ -603,6 +678,10 @@ static const struct coresight_ops_link tmc_etf_link_ops = {
.disable = tmc_disable_etf_link,
};
static const struct coresight_ops_panic tmc_etf_sync_ops = {
.sync = tmc_panic_sync_etf,
};
const struct coresight_ops tmc_etb_cs_ops = {
.sink_ops = &tmc_etf_sink_ops,
};
@ -610,6 +689,7 @@ const struct coresight_ops tmc_etb_cs_ops = {
const struct coresight_ops tmc_etf_cs_ops = {
.sink_ops = &tmc_etf_sink_ops,
.link_ops = &tmc_etf_link_ops,
.panic_ops = &tmc_etf_sync_ops,
};
int tmc_read_prepare_etb(struct tmc_drvdata *drvdata)

View File

@ -1814,6 +1814,74 @@ static int tmc_disable_etr_sink(struct coresight_device *csdev)
return 0;
}
static int tmc_panic_sync_etr(struct coresight_device *csdev)
{
u32 val;
struct tmc_crash_metadata *mdata;
struct tmc_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
mdata = (struct tmc_crash_metadata *)drvdata->crash_mdata.vaddr;
if (!drvdata->etr_buf)
return 0;
/* Being in RESRV mode implies valid reserved memory as well */
if (drvdata->etr_buf->mode != ETR_MODE_RESRV)
return 0;
if (!tmc_has_crash_mdata_buffer(drvdata))
return 0;
CS_UNLOCK(drvdata->base);
/* Proceed only if ETR is enabled */
val = readl(drvdata->base + TMC_CTL);
if (!(val & TMC_CTL_CAPT_EN))
goto out;
val = readl(drvdata->base + TMC_FFSR);
/* Do manual flush and stop only if its not auto-stopped */
if (!(val & TMC_FFSR_FT_STOPPED)) {
dev_dbg(&csdev->dev,
"%s: Triggering manual flush\n", __func__);
tmc_flush_and_stop(drvdata);
} else
tmc_wait_for_tmcready(drvdata);
/* Sync registers from hardware to metadata region */
mdata->tmc_ram_size = readl(drvdata->base + TMC_RSZ);
mdata->tmc_sts = readl(drvdata->base + TMC_STS);
mdata->tmc_mode = readl(drvdata->base + TMC_MODE);
mdata->tmc_ffcr = readl(drvdata->base + TMC_FFCR);
mdata->tmc_ffsr = readl(drvdata->base + TMC_FFSR);
mdata->tmc_rrp = tmc_read_rrp(drvdata);
mdata->tmc_rwp = tmc_read_rwp(drvdata);
mdata->tmc_dba = tmc_read_dba(drvdata);
mdata->trace_paddr = drvdata->resrv_buf.paddr;
mdata->version = CS_CRASHDATA_VERSION;
/*
* Make sure all previous writes are ordered,
* before we mark valid
*/
dmb(sy);
mdata->valid = true;
/*
* Below order need to maintained, since crc of metadata
* is dependent on first
*/
mdata->crc32_tdata = find_crash_tracedata_crc(drvdata, mdata);
mdata->crc32_mdata = find_crash_metadata_crc(mdata);
tmc_disable_hw(drvdata);
dev_dbg(&csdev->dev, "%s: success\n", __func__);
out:
CS_UNLOCK(drvdata->base);
return 0;
}
static const struct coresight_ops_sink tmc_etr_sink_ops = {
.enable = tmc_enable_etr_sink,
.disable = tmc_disable_etr_sink,
@ -1822,8 +1890,13 @@ static const struct coresight_ops_sink tmc_etr_sink_ops = {
.free_buffer = tmc_free_etr_buffer,
};
static const struct coresight_ops_panic tmc_etr_sync_ops = {
.sync = tmc_panic_sync_etr,
};
const struct coresight_ops tmc_etr_cs_ops = {
.sink_ops = &tmc_etr_sink_ops,
.panic_ops = &tmc_etr_sync_ops,
};
int tmc_read_prepare_etr(struct tmc_drvdata *drvdata)

View File

@ -12,6 +12,7 @@
#include <linux/miscdevice.h>
#include <linux/mutex.h>
#include <linux/refcount.h>
#include <linux/crc32.h>
#define TMC_RSZ 0x004
#define TMC_STS 0x00c
@ -76,6 +77,9 @@
#define TMC_AXICTL_AXCACHE_OS (0xf << 2)
#define TMC_AXICTL_ARCACHE_OS (0xf << 16)
/* TMC_FFSR - 0x300 */
#define TMC_FFSR_FT_STOPPED BIT(1)
/* TMC_FFCR - 0x304 */
#define TMC_FFCR_FLUSHMAN_BIT 6
#define TMC_FFCR_EN_FMT BIT(0)
@ -94,6 +98,9 @@
#define TMC_AUTH_NSID_MASK GENMASK(1, 0)
/* Major version 1 Minor version 0 */
#define CS_CRASHDATA_VERSION (1 << 16)
enum tmc_config_type {
TMC_CONFIG_TYPE_ETB,
TMC_CONFIG_TYPE_ETR,
@ -131,6 +138,25 @@ enum tmc_mem_intf_width {
#define CORESIGHT_SOC_600_ETR_CAPS \
(TMC_ETR_SAVE_RESTORE | TMC_ETR_AXI_ARCACHE)
/* TMC metadata region for ETR and ETF configurations */
struct tmc_crash_metadata {
uint32_t crc32_mdata; /* crc of metadata */
uint32_t crc32_tdata; /* crc of tracedata */
uint32_t version; /* 31:16 Major version, 15:0 Minor version */
uint32_t valid; /* Indicate if this ETF/ETR was enabled */
uint32_t tmc_ram_size; /* Ram Size register */
uint32_t tmc_sts; /* Status register */
uint32_t tmc_mode; /* Mode register */
uint32_t tmc_ffcr; /* Formatter and flush control register */
uint32_t tmc_ffsr; /* Formatter and flush status register */
uint32_t reserved32;
uint64_t tmc_rrp; /* Ram Read pointer register */
uint64_t tmc_rwp; /* Ram Write pointer register */
uint64_t tmc_dba; /* Data buffer address register */
uint64_t trace_paddr; /* Phys address of trace buffer */
uint64_t reserved64[3];
};
enum etr_mode {
ETR_MODE_FLAT, /* Uses contiguous flat buffer */
ETR_MODE_ETR_SG, /* Uses in-built TMC ETR SG mechanism */
@ -205,6 +231,8 @@ struct tmc_resrv_buf {
* retention (after crash) only when ETR_MODE_RESRV buffer
* mode is enabled. Used by ETF for trace data retention
* (after crash) by default.
* @crash_mdata: Reserved memory for storing tmc crash metadata.
* Used by ETR/ETF.
*/
struct tmc_drvdata {
struct clk *pclk;
@ -231,6 +259,7 @@ struct tmc_drvdata {
struct etr_buf *sysfs_buf;
struct etr_buf *perf_buf;
struct tmc_resrv_buf resrv_buf;
struct tmc_resrv_buf crash_mdata;
};
struct etr_buf_operations {
@ -356,6 +385,43 @@ static inline bool tmc_has_reserved_buffer(struct tmc_drvdata *drvdata)
return false;
}
static inline bool tmc_has_crash_mdata_buffer(struct tmc_drvdata *drvdata)
{
if (drvdata->crash_mdata.vaddr &&
drvdata->crash_mdata.size)
return true;
return false;
}
static inline void tmc_crashdata_set_invalid(struct tmc_drvdata *drvdata)
{
struct tmc_crash_metadata *mdata;
mdata = (struct tmc_crash_metadata *)drvdata->crash_mdata.vaddr;
if (tmc_has_crash_mdata_buffer(drvdata))
mdata->valid = false;
}
static inline uint32_t find_crash_metadata_crc(struct tmc_crash_metadata *md)
{
unsigned long crc_size;
crc_size = sizeof(struct tmc_crash_metadata) -
offsetof(struct tmc_crash_metadata, crc32_tdata);
return crc32_le(0, (void *)&md->crc32_tdata, crc_size);
}
static inline uint32_t find_crash_tracedata_crc(struct tmc_drvdata *drvdata,
struct tmc_crash_metadata *md)
{
unsigned long crc_size;
/* Take CRC of configured buffer size to keep it simple */
crc_size = md->tmc_ram_size << 2;
return crc32_le(0, (void *)drvdata->resrv_buf.vaddr, crc_size);
}
struct coresight_device *tmc_etr_get_catu_device(struct tmc_drvdata *drvdata);
void tmc_etr_set_catu_ops(const struct etr_buf_operations *catu);