mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-04-12 16:47:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

spi: offload: fix use after free

Browse Source 
Fix a use after free bug in devm_spi_offload_get() where a pointer
was dereferenced after being freed. Instead, add a new local variable
to avoid needing to use the resource pointer to access the offload
pointer.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202502112344.7ggtFzyn-lkp@intel.com/
Fixes: 5a19e1985d01 ("spi: axi-spi-engine: implement offload support")
Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250212-spi-offload-fixes-v1-2-e192c69e3bb3@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
David Lechner 2025-02-12 11:33:13 -06:00 committed by Mark Brown
parent d795a052b0
commit e957c96455
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/spi/spi-offload.c
View File

@ -108,6 +108,7 @@ struct spi_offload *devm_spi_offload_get(struct device *dev,
const struct spi_offload_config *config) const struct spi_offload_config *config)
{ {
struct spi_controller_and_offload *resource; struct spi_controller_and_offload *resource;
struct spi_offload *offload;
int ret; int ret;
if (!spi || !config) if (!spi || !config)
@ -120,18 +121,20 @@ struct spi_offload *devm_spi_offload_get(struct device *dev,
if (!resource) if (!resource)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
resource->controller = spi->controller; offload = spi->controller->get_offload(spi, config);
resource->offload = spi->controller->get_offload(spi, config); if (IS_ERR(offload)) {
if (IS_ERR(resource->offload)) {
kfree(resource); kfree(resource);
return resource->offload; return offload;
} }
resource->controller = spi->controller;
resource->offload = offload;
ret = devm_add_action_or_reset(dev, spi_offload_put, resource); ret = devm_add_action_or_reset(dev, spi_offload_put, resource);
if (ret) if (ret)
return ERR_PTR(ret); return ERR_PTR(ret);
return resource->offload; return offload;
} }
EXPORT_SYMBOL_GPL(devm_spi_offload_get); EXPORT_SYMBOL_GPL(devm_spi_offload_get);