mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-04-12 16:47:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

gpio: davinci: use value returning setters

Browse Source 
struct gpio_chip now has additional variants of the set(_multiple)
driver callbacks that return an integer to indicate success or failure.
Convert the driver to using them.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20250220-gpio-set-retval-v2-14-bc4cfd38dae3@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Bartosz Golaszewski 2025-02-20 10:57:11 +01:00
parent 4b28762caa
commit f01436c2a0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/gpio/gpio-davinci.c
View File

@ -139,7 +139,7 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
/* /*
* Assuming the pin is muxed as a gpio output, set its output value. * Assuming the pin is muxed as a gpio output, set its output value.
*/ */
static void static int
davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int value) davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
{ {
struct davinci_gpio_controller *d = gpiochip_get_data(chip); struct davinci_gpio_controller *d = gpiochip_get_data(chip);
@ -150,6 +150,8 @@ davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
writel_relaxed(__gpio_mask(offset), writel_relaxed(__gpio_mask(offset),
value ? &g->set_data : &g->clr_data); value ? &g->set_data : &g->clr_data);
return 0;
} }
static int davinci_gpio_probe(struct platform_device *pdev) static int davinci_gpio_probe(struct platform_device *pdev)
@ -209,7 +211,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
chips->chip.direction_input = davinci_direction_in; chips->chip.direction_input = davinci_direction_in;
chips->chip.get = davinci_gpio_get; chips->chip.get = davinci_gpio_get;
chips->chip.direction_output = davinci_direction_out; chips->chip.direction_output = davinci_direction_out;
chips->chip.set = davinci_gpio_set; chips->chip.set_rv = davinci_gpio_set;
chips->chip.ngpio = ngpio; chips->chip.ngpio = ngpio;
chips->chip.base = -1; chips->chip.base = -1;