mirror of
https://github.com/torvalds/linux.git
synced 2025-04-06 00:16:18 +00:00
a5a056c8d2
In drivers/hid/, most drivers depend on CONFIG_HID, while a couple of the
drivers in subdirectories instead depend on CONFIG_HID_SUPPORT and use
'select HID'. With the newly added INTEL_THC_HID, this causes a build
warning for a circular dependency:
WARNING: unmet direct dependencies detected for HID
Depends on [m]: HID_SUPPORT [=y] && INPUT [=m]
Selected by [y]:
- INTEL_THC_HID [=y] && HID_SUPPORT [=y] && X86_64 [=y] && PCI [=y] && ACPI [=y]
WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
- HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y]
- GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y]
- HID_WIIMOTE [=y] && HID_SUPPORT [=y] && HID [=y] && LEDS_CLASS [=y]
- ZEROPLUS_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ZEROPLUS [=y]
Selected by [m]:
- HID_ACRUX_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ACRUX [=m]
- HID_EMS_FF [=m] && HID_SUPPORT [=y] && HID [=y]
- HID_GOOGLE_STADIA_FF [=m] && HID_SUPPORT [=y] && HID [=y]
- PANTHERLORD_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_PANTHERLORD [=m]
It's better to be consistent and always use 'depends on HID' for HID
drivers. The notable exception here is USB_KBD/USB_MOUSE, which are
alternative implementations that do not depend on the HID subsystem.
Do this by extending the "if HID" section below, which means that a few
of the duplicate "depends on HID" and "depends on INPUT" statements
can be removed in the process.
Fixes: 1b2d05384c29 ("HID: intel-thc-hid: Add basic THC driver skeleton")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Reviewed-by: Even Xu <even.xu@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
34 lines
1.1 KiB
Plaintext
34 lines
1.1 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
menu "Intel ISH HID support"
|
|
depends on (X86_64 || COMPILE_TEST) && PCI
|
|
|
|
config INTEL_ISH_HID
|
|
tristate "Intel Integrated Sensor Hub"
|
|
default n
|
|
depends on X86
|
|
help
|
|
The Integrated Sensor Hub (ISH) enables the ability to offload
|
|
sensor polling and algorithm processing to a dedicated low power
|
|
processor in the chipset. This allows the core processor to go into
|
|
low power modes more often, resulting in the increased battery life.
|
|
The current processors that support ISH are: Cherrytrail, Skylake,
|
|
Broxton and Kaby Lake.
|
|
|
|
Say Y here if you want to support Intel ISH. If unsure, say N.
|
|
|
|
config INTEL_ISH_FIRMWARE_DOWNLOADER
|
|
tristate "Host Firmware Load feature for Intel ISH"
|
|
depends on INTEL_ISH_HID
|
|
depends on X86
|
|
help
|
|
The Integrated Sensor Hub (ISH) enables the kernel to offload
|
|
sensor polling and algorithm processing to a dedicated low power
|
|
processor in the chipset.
|
|
|
|
The Host Firmware Load feature adds support to load the ISH
|
|
firmware from host file system at boot.
|
|
|
|
Say M here if you want to support Host Firmware Loading feature
|
|
for Intel ISH. If unsure, say N.
|
|
endmenu
|