mirror of
https://github.com/torvalds/linux.git
synced 2025-04-12 06:49:52 +00:00

On a board running ntpd and gpsd, I'm seeing a consistent use-after-free in sys_exit() from gpsd when rebooting: pps pps1: removed ------------[ cut here ]------------ kobject: '(null)' (00000000db4bec24): is not initialized, yet kobject_put() is being called. WARNING: CPU: 2 PID: 440 at lib/kobject.c:734 kobject_put+0x120/0x150 CPU: 2 UID: 299 PID: 440 Comm: gpsd Not tainted 6.11.0-rc6-00308-gb31c44928842 #1 Hardware name: Raspberry Pi 4 Model B Rev 1.1 (DT) pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : kobject_put+0x120/0x150 lr : kobject_put+0x120/0x150 sp : ffffffc0803d3ae0 x29: ffffffc0803d3ae0 x28: ffffff8042dc9738 x27: 0000000000000001 x26: 0000000000000000 x25: ffffff8042dc9040 x24: ffffff8042dc9440 x23: ffffff80402a4620 x22: ffffff8042ef4bd0 x21: ffffff80405cb600 x20: 000000000008001b x19: ffffff8040b3b6e0 x18: 0000000000000000 x17: 0000000000000000 x16: 0000000000000000 x15: 696e6920746f6e20 x14: 7369203a29343263 x13: 205d303434542020 x12: 0000000000000000 x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 Call trace: kobject_put+0x120/0x150 cdev_put+0x20/0x3c __fput+0x2c4/0x2d8 ____fput+0x1c/0x38 task_work_run+0x70/0xfc do_exit+0x2a0/0x924 do_group_exit+0x34/0x90 get_signal+0x7fc/0x8c0 do_signal+0x128/0x13b4 do_notify_resume+0xdc/0x160 el0_svc+0xd4/0xf8 el0t_64_sync_handler+0x140/0x14c el0t_64_sync+0x190/0x194 ---[ end trace 0000000000000000 ]--- ...followed by more symptoms of corruption, with similar stacks: refcount_t: underflow; use-after-free. kernel BUG at lib/list_debug.c:62! Kernel panic - not syncing: Oops - BUG: Fatal exception This happens because pps_device_destruct() frees the pps_device with the embedded cdev immediately after calling cdev_del(), but, as the comment above cdev_del() notes, fops for previously opened cdevs are still callable even after cdev_del() returns. I think this bug has always been there: I can't explain why it suddenly started happening every time I reboot this particular board. In commit d953e0e837e6 ("pps: Fix a use-after free bug when unregistering a source."), George Spelvin suggested removing the embedded cdev. That seems like the simplest way to fix this, so I've implemented his suggestion, using __register_chrdev() with pps_idr becoming the source of truth for which minor corresponds to which device. But now that pps_idr defines userspace visibility instead of cdev_add(), we need to be sure the pps->dev refcount can't reach zero while userspace can still find it again. So, the idr_remove() call moves to pps_unregister_cdev(), and pps_idr now holds a reference to pps->dev. pps_core: source serial1 got cdev (251:1) <...> pps pps1: removed pps_core: unregistering pps1 pps_core: deallocating pps1 Fixes: d953e0e837e6 ("pps: Fix a use-after free bug when unregistering a source.") Cc: stable@vger.kernel.org Signed-off-by: Calvin Owens <calvin@wbinvd.org> Reviewed-by: Michal Schmidt <mschmidt@redhat.com> Link: https://lore.kernel.org/r/a17975fd5ae99385791929e563f72564edbcf28f.1731383727.git.calvin@wbinvd.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
229 lines
5.5 KiB
C
229 lines
5.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* pps_parport.c -- kernel parallel port PPS client
|
|
*
|
|
* Copyright (C) 2009 Alexander Gordeev <lasaine@lvk.cs.msu.su>
|
|
*/
|
|
|
|
|
|
/*
|
|
* TODO:
|
|
* implement echo over SEL pin
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/irqnr.h>
|
|
#include <linux/time.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/parport.h>
|
|
#include <linux/pps_kernel.h>
|
|
|
|
/* module parameters */
|
|
|
|
#define CLEAR_WAIT_MAX 100
|
|
#define CLEAR_WAIT_MAX_ERRORS 5
|
|
|
|
static unsigned int clear_wait = 100;
|
|
MODULE_PARM_DESC(clear_wait,
|
|
"Maximum number of port reads when polling for signal clear,"
|
|
" zero turns clear edge capture off entirely");
|
|
module_param(clear_wait, uint, 0);
|
|
|
|
static DEFINE_IDA(pps_client_index);
|
|
|
|
/* internal per port structure */
|
|
struct pps_client_pp {
|
|
struct pardevice *pardev; /* parport device */
|
|
struct pps_device *pps; /* PPS device */
|
|
unsigned int cw; /* port clear timeout */
|
|
unsigned int cw_err; /* number of timeouts */
|
|
int index; /* device number */
|
|
};
|
|
|
|
static inline int signal_is_set(struct parport *port)
|
|
{
|
|
return (port->ops->read_status(port) & PARPORT_STATUS_ACK) != 0;
|
|
}
|
|
|
|
/* parport interrupt handler */
|
|
static void parport_irq(void *handle)
|
|
{
|
|
struct pps_event_time ts_assert, ts_clear;
|
|
struct pps_client_pp *dev = handle;
|
|
struct parport *port = dev->pardev->port;
|
|
unsigned int i;
|
|
unsigned long flags;
|
|
|
|
/* first of all we get the time stamp... */
|
|
pps_get_ts(&ts_assert);
|
|
|
|
if (dev->cw == 0)
|
|
/* clear edge capture disabled */
|
|
goto out_assert;
|
|
|
|
/* try capture the clear edge */
|
|
|
|
/* We have to disable interrupts here. The idea is to prevent
|
|
* other interrupts on the same processor to introduce random
|
|
* lags while polling the port. Reading from IO port is known
|
|
* to take approximately 1us while other interrupt handlers can
|
|
* take much more potentially.
|
|
*
|
|
* Interrupts won't be disabled for a long time because the
|
|
* number of polls is limited by clear_wait parameter which is
|
|
* kept rather low. So it should never be an issue.
|
|
*/
|
|
local_irq_save(flags);
|
|
/* check the signal (no signal means the pulse is lost this time) */
|
|
if (!signal_is_set(port)) {
|
|
local_irq_restore(flags);
|
|
dev_err(&dev->pps->dev, "lost the signal\n");
|
|
goto out_assert;
|
|
}
|
|
|
|
/* poll the port until the signal is unset */
|
|
for (i = dev->cw; i; i--)
|
|
if (!signal_is_set(port)) {
|
|
pps_get_ts(&ts_clear);
|
|
local_irq_restore(flags);
|
|
dev->cw_err = 0;
|
|
goto out_both;
|
|
}
|
|
local_irq_restore(flags);
|
|
|
|
/* timeout */
|
|
dev->cw_err++;
|
|
if (dev->cw_err >= CLEAR_WAIT_MAX_ERRORS) {
|
|
dev_err(&dev->pps->dev, "disabled clear edge capture after %d"
|
|
" timeouts\n", dev->cw_err);
|
|
dev->cw = 0;
|
|
dev->cw_err = 0;
|
|
}
|
|
|
|
out_assert:
|
|
/* fire assert event */
|
|
pps_event(dev->pps, &ts_assert,
|
|
PPS_CAPTUREASSERT, NULL);
|
|
return;
|
|
|
|
out_both:
|
|
/* fire assert event */
|
|
pps_event(dev->pps, &ts_assert,
|
|
PPS_CAPTUREASSERT, NULL);
|
|
/* fire clear event */
|
|
pps_event(dev->pps, &ts_clear,
|
|
PPS_CAPTURECLEAR, NULL);
|
|
return;
|
|
}
|
|
|
|
static void parport_attach(struct parport *port)
|
|
{
|
|
struct pardev_cb pps_client_cb;
|
|
int index;
|
|
struct pps_client_pp *device;
|
|
struct pps_source_info info = {
|
|
.name = KBUILD_MODNAME,
|
|
.path = "",
|
|
.mode = PPS_CAPTUREBOTH | \
|
|
PPS_OFFSETASSERT | PPS_OFFSETCLEAR | \
|
|
PPS_ECHOASSERT | PPS_ECHOCLEAR | \
|
|
PPS_CANWAIT | PPS_TSFMT_TSPEC,
|
|
.owner = THIS_MODULE,
|
|
.dev = NULL
|
|
};
|
|
|
|
if (clear_wait > CLEAR_WAIT_MAX) {
|
|
pr_err("clear_wait value should be not greater then %d\n",
|
|
CLEAR_WAIT_MAX);
|
|
return;
|
|
}
|
|
|
|
device = kzalloc(sizeof(struct pps_client_pp), GFP_KERNEL);
|
|
if (!device) {
|
|
pr_err("memory allocation failed, not attaching\n");
|
|
return;
|
|
}
|
|
|
|
index = ida_alloc(&pps_client_index, GFP_KERNEL);
|
|
if (index < 0)
|
|
goto err_free_device;
|
|
|
|
memset(&pps_client_cb, 0, sizeof(pps_client_cb));
|
|
pps_client_cb.private = device;
|
|
pps_client_cb.irq_func = parport_irq;
|
|
pps_client_cb.flags = PARPORT_FLAG_EXCL;
|
|
device->pardev = parport_register_dev_model(port,
|
|
KBUILD_MODNAME,
|
|
&pps_client_cb,
|
|
index);
|
|
if (!device->pardev) {
|
|
pr_err("couldn't register with %s\n", port->name);
|
|
goto err_free_ida;
|
|
}
|
|
|
|
if (parport_claim_or_block(device->pardev) < 0) {
|
|
pr_err("couldn't claim %s\n", port->name);
|
|
goto err_unregister_dev;
|
|
}
|
|
|
|
device->pps = pps_register_source(&info,
|
|
PPS_CAPTUREBOTH | PPS_OFFSETASSERT | PPS_OFFSETCLEAR);
|
|
if (IS_ERR(device->pps)) {
|
|
pr_err("couldn't register PPS source\n");
|
|
goto err_release_dev;
|
|
}
|
|
|
|
device->cw = clear_wait;
|
|
|
|
port->ops->enable_irq(port);
|
|
device->index = index;
|
|
|
|
pr_info("attached to %s\n", port->name);
|
|
|
|
return;
|
|
|
|
err_release_dev:
|
|
parport_release(device->pardev);
|
|
err_unregister_dev:
|
|
parport_unregister_device(device->pardev);
|
|
err_free_ida:
|
|
ida_free(&pps_client_index, index);
|
|
err_free_device:
|
|
kfree(device);
|
|
}
|
|
|
|
static void parport_detach(struct parport *port)
|
|
{
|
|
struct pardevice *pardev = port->cad;
|
|
struct pps_client_pp *device;
|
|
|
|
/* FIXME: oooh, this is ugly! */
|
|
if (!pardev || strcmp(pardev->name, KBUILD_MODNAME))
|
|
/* not our port */
|
|
return;
|
|
|
|
device = pardev->private;
|
|
|
|
port->ops->disable_irq(port);
|
|
pps_unregister_source(device->pps);
|
|
parport_release(pardev);
|
|
parport_unregister_device(pardev);
|
|
ida_free(&pps_client_index, device->index);
|
|
kfree(device);
|
|
}
|
|
|
|
static struct parport_driver pps_parport_driver = {
|
|
.name = KBUILD_MODNAME,
|
|
.match_port = parport_attach,
|
|
.detach = parport_detach,
|
|
};
|
|
module_parport_driver(pps_parport_driver);
|
|
|
|
MODULE_AUTHOR("Alexander Gordeev <lasaine@lvk.cs.msu.su>");
|
|
MODULE_DESCRIPTION("parallel port PPS client");
|
|
MODULE_LICENSE("GPL");
|