mirror of
https://github.com/torvalds/linux.git
synced 2025-04-06 00:16:18 +00:00
4be214c269
Previously, bch2_bkey_sectors_need_rebalance() called bch2_target_accepts_data(), checking whether the target is writable. However, this means that adding or removing devices from a target would change the value of bch2_bkey_sectors_need_rebalance() for an existing extent; this needs to be invariant so that the extent trigger can correctly maintain rebalance_work accounting. Instead, check target_accepts_data() in io_opts_to_rebalance_opts(), before creating the bch_extent_rebalance entry. This fixes (one?) cause of rebalance_work accounting being off. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
58 lines
1.6 KiB
C
58 lines
1.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _BCACHEFS_REBALANCE_H
|
|
#define _BCACHEFS_REBALANCE_H
|
|
|
|
#include "compress.h"
|
|
#include "disk_groups.h"
|
|
#include "opts.h"
|
|
#include "rebalance_types.h"
|
|
|
|
static inline struct bch_extent_rebalance io_opts_to_rebalance_opts(struct bch_fs *c,
|
|
struct bch_io_opts *opts)
|
|
{
|
|
struct bch_extent_rebalance r = {
|
|
.type = BIT(BCH_EXTENT_ENTRY_rebalance),
|
|
#define x(_name) \
|
|
._name = opts->_name, \
|
|
._name##_from_inode = opts->_name##_from_inode,
|
|
BCH_REBALANCE_OPTS()
|
|
#undef x
|
|
};
|
|
|
|
if (r.background_target &&
|
|
!bch2_target_accepts_data(c, BCH_DATA_user, r.background_target))
|
|
r.background_target = 0;
|
|
|
|
return r;
|
|
};
|
|
|
|
u64 bch2_bkey_sectors_need_rebalance(struct bch_fs *, struct bkey_s_c);
|
|
int bch2_bkey_set_needs_rebalance(struct bch_fs *, struct bch_io_opts *, struct bkey_i *);
|
|
int bch2_get_update_rebalance_opts(struct btree_trans *,
|
|
struct bch_io_opts *,
|
|
struct btree_iter *,
|
|
struct bkey_s_c);
|
|
|
|
int bch2_set_rebalance_needs_scan_trans(struct btree_trans *, u64);
|
|
int bch2_set_rebalance_needs_scan(struct bch_fs *, u64 inum);
|
|
int bch2_set_fs_needs_rebalance(struct bch_fs *);
|
|
|
|
static inline void rebalance_wakeup(struct bch_fs *c)
|
|
{
|
|
struct task_struct *p;
|
|
|
|
rcu_read_lock();
|
|
p = rcu_dereference(c->rebalance.thread);
|
|
if (p)
|
|
wake_up_process(p);
|
|
rcu_read_unlock();
|
|
}
|
|
|
|
void bch2_rebalance_status_to_text(struct printbuf *, struct bch_fs *);
|
|
|
|
void bch2_rebalance_stop(struct bch_fs *);
|
|
int bch2_rebalance_start(struct bch_fs *);
|
|
void bch2_fs_rebalance_init(struct bch_fs *);
|
|
|
|
#endif /* _BCACHEFS_REBALANCE_H */
|