mirror of
https://github.com/torvalds/linux.git
synced 2025-04-12 16:47:42 +00:00

On a board running ntpd and gpsd, I'm seeing a consistent use-after-free in sys_exit() from gpsd when rebooting: pps pps1: removed ------------[ cut here ]------------ kobject: '(null)' (00000000db4bec24): is not initialized, yet kobject_put() is being called. WARNING: CPU: 2 PID: 440 at lib/kobject.c:734 kobject_put+0x120/0x150 CPU: 2 UID: 299 PID: 440 Comm: gpsd Not tainted 6.11.0-rc6-00308-gb31c44928842 #1 Hardware name: Raspberry Pi 4 Model B Rev 1.1 (DT) pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : kobject_put+0x120/0x150 lr : kobject_put+0x120/0x150 sp : ffffffc0803d3ae0 x29: ffffffc0803d3ae0 x28: ffffff8042dc9738 x27: 0000000000000001 x26: 0000000000000000 x25: ffffff8042dc9040 x24: ffffff8042dc9440 x23: ffffff80402a4620 x22: ffffff8042ef4bd0 x21: ffffff80405cb600 x20: 000000000008001b x19: ffffff8040b3b6e0 x18: 0000000000000000 x17: 0000000000000000 x16: 0000000000000000 x15: 696e6920746f6e20 x14: 7369203a29343263 x13: 205d303434542020 x12: 0000000000000000 x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000 x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000 Call trace: kobject_put+0x120/0x150 cdev_put+0x20/0x3c __fput+0x2c4/0x2d8 ____fput+0x1c/0x38 task_work_run+0x70/0xfc do_exit+0x2a0/0x924 do_group_exit+0x34/0x90 get_signal+0x7fc/0x8c0 do_signal+0x128/0x13b4 do_notify_resume+0xdc/0x160 el0_svc+0xd4/0xf8 el0t_64_sync_handler+0x140/0x14c el0t_64_sync+0x190/0x194 ---[ end trace 0000000000000000 ]--- ...followed by more symptoms of corruption, with similar stacks: refcount_t: underflow; use-after-free. kernel BUG at lib/list_debug.c:62! Kernel panic - not syncing: Oops - BUG: Fatal exception This happens because pps_device_destruct() frees the pps_device with the embedded cdev immediately after calling cdev_del(), but, as the comment above cdev_del() notes, fops for previously opened cdevs are still callable even after cdev_del() returns. I think this bug has always been there: I can't explain why it suddenly started happening every time I reboot this particular board. In commit d953e0e837e6 ("pps: Fix a use-after free bug when unregistering a source."), George Spelvin suggested removing the embedded cdev. That seems like the simplest way to fix this, so I've implemented his suggestion, using __register_chrdev() with pps_idr becoming the source of truth for which minor corresponds to which device. But now that pps_idr defines userspace visibility instead of cdev_add(), we need to be sure the pps->dev refcount can't reach zero while userspace can still find it again. So, the idr_remove() call moves to pps_unregister_cdev(), and pps_idr now holds a reference to pps->dev. pps_core: source serial1 got cdev (251:1) <...> pps pps1: removed pps_core: unregistering pps1 pps_core: deallocating pps1 Fixes: d953e0e837e6 ("pps: Fix a use-after free bug when unregistering a source.") Cc: stable@vger.kernel.org Signed-off-by: Calvin Owens <calvin@wbinvd.org> Reviewed-by: Michal Schmidt <mschmidt@redhat.com> Link: https://lore.kernel.org/r/a17975fd5ae99385791929e563f72564edbcf28f.1731383727.git.calvin@wbinvd.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
224 lines
5.4 KiB
C
224 lines
5.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* kernel API
|
|
*
|
|
* Copyright (C) 2005-2009 Rodolfo Giometti <giometti@linux.it>
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/time.h>
|
|
#include <linux/timex.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/pps_kernel.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "kc.h"
|
|
|
|
/*
|
|
* Local functions
|
|
*/
|
|
|
|
static void pps_add_offset(struct pps_ktime *ts, struct pps_ktime *offset)
|
|
{
|
|
ts->nsec += offset->nsec;
|
|
while (ts->nsec >= NSEC_PER_SEC) {
|
|
ts->nsec -= NSEC_PER_SEC;
|
|
ts->sec++;
|
|
}
|
|
while (ts->nsec < 0) {
|
|
ts->nsec += NSEC_PER_SEC;
|
|
ts->sec--;
|
|
}
|
|
ts->sec += offset->sec;
|
|
}
|
|
|
|
static void pps_echo_client_default(struct pps_device *pps, int event,
|
|
void *data)
|
|
{
|
|
dev_info(&pps->dev, "echo %s %s\n",
|
|
event & PPS_CAPTUREASSERT ? "assert" : "",
|
|
event & PPS_CAPTURECLEAR ? "clear" : "");
|
|
}
|
|
|
|
/*
|
|
* Exported functions
|
|
*/
|
|
|
|
/* pps_register_source - add a PPS source in the system
|
|
* @info: the PPS info struct
|
|
* @default_params: the default PPS parameters of the new source
|
|
*
|
|
* This function is used to add a new PPS source in the system. The new
|
|
* source is described by info's fields and it will have, as default PPS
|
|
* parameters, the ones specified into default_params.
|
|
*
|
|
* The function returns, in case of success, the PPS device. Otherwise
|
|
* ERR_PTR(errno).
|
|
*/
|
|
|
|
struct pps_device *pps_register_source(struct pps_source_info *info,
|
|
int default_params)
|
|
{
|
|
struct pps_device *pps;
|
|
int err;
|
|
|
|
/* Sanity checks */
|
|
if ((info->mode & default_params) != default_params) {
|
|
pr_err("%s: unsupported default parameters\n",
|
|
info->name);
|
|
err = -EINVAL;
|
|
goto pps_register_source_exit;
|
|
}
|
|
if ((info->mode & (PPS_TSFMT_TSPEC | PPS_TSFMT_NTPFP)) == 0) {
|
|
pr_err("%s: unspecified time format\n",
|
|
info->name);
|
|
err = -EINVAL;
|
|
goto pps_register_source_exit;
|
|
}
|
|
|
|
/* Allocate memory for the new PPS source struct */
|
|
pps = kzalloc(sizeof(struct pps_device), GFP_KERNEL);
|
|
if (pps == NULL) {
|
|
err = -ENOMEM;
|
|
goto pps_register_source_exit;
|
|
}
|
|
|
|
/* These initializations must be done before calling idr_alloc()
|
|
* in order to avoid reces into pps_event().
|
|
*/
|
|
pps->params.api_version = PPS_API_VERS;
|
|
pps->params.mode = default_params;
|
|
pps->info = *info;
|
|
|
|
/* check for default echo function */
|
|
if ((pps->info.mode & (PPS_ECHOASSERT | PPS_ECHOCLEAR)) &&
|
|
pps->info.echo == NULL)
|
|
pps->info.echo = pps_echo_client_default;
|
|
|
|
init_waitqueue_head(&pps->queue);
|
|
spin_lock_init(&pps->lock);
|
|
|
|
/* Create the char device */
|
|
err = pps_register_cdev(pps);
|
|
if (err < 0) {
|
|
pr_err("%s: unable to create char device\n",
|
|
info->name);
|
|
goto kfree_pps;
|
|
}
|
|
|
|
dev_dbg(&pps->dev, "new PPS source %s\n", info->name);
|
|
|
|
return pps;
|
|
|
|
kfree_pps:
|
|
kfree(pps);
|
|
|
|
pps_register_source_exit:
|
|
pr_err("%s: unable to register source\n", info->name);
|
|
|
|
return ERR_PTR(err);
|
|
}
|
|
EXPORT_SYMBOL(pps_register_source);
|
|
|
|
/* pps_unregister_source - remove a PPS source from the system
|
|
* @pps: the PPS source
|
|
*
|
|
* This function is used to remove a previously registered PPS source from
|
|
* the system.
|
|
*/
|
|
|
|
void pps_unregister_source(struct pps_device *pps)
|
|
{
|
|
pps_kc_remove(pps);
|
|
pps_unregister_cdev(pps);
|
|
|
|
/* don't have to kfree(pps) here because it will be done on
|
|
* device destruction */
|
|
}
|
|
EXPORT_SYMBOL(pps_unregister_source);
|
|
|
|
/* pps_event - register a PPS event into the system
|
|
* @pps: the PPS device
|
|
* @ts: the event timestamp
|
|
* @event: the event type
|
|
* @data: userdef pointer
|
|
*
|
|
* This function is used by each PPS client in order to register a new
|
|
* PPS event into the system (it's usually called inside an IRQ handler).
|
|
*
|
|
* If an echo function is associated with the PPS device it will be called
|
|
* as:
|
|
* pps->info.echo(pps, event, data);
|
|
*/
|
|
void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
|
|
void *data)
|
|
{
|
|
unsigned long flags;
|
|
int captured = 0;
|
|
struct pps_ktime ts_real = { .sec = 0, .nsec = 0, .flags = 0 };
|
|
|
|
/* check event type */
|
|
BUG_ON((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0);
|
|
|
|
dev_dbg(&pps->dev, "PPS event at %lld.%09ld\n",
|
|
(s64)ts->ts_real.tv_sec, ts->ts_real.tv_nsec);
|
|
|
|
timespec_to_pps_ktime(&ts_real, ts->ts_real);
|
|
|
|
spin_lock_irqsave(&pps->lock, flags);
|
|
|
|
/* Must call the echo function? */
|
|
if ((pps->params.mode & (PPS_ECHOASSERT | PPS_ECHOCLEAR)))
|
|
pps->info.echo(pps, event, data);
|
|
|
|
/* Check the event */
|
|
pps->current_mode = pps->params.mode;
|
|
if (event & pps->params.mode & PPS_CAPTUREASSERT) {
|
|
/* We have to add an offset? */
|
|
if (pps->params.mode & PPS_OFFSETASSERT)
|
|
pps_add_offset(&ts_real,
|
|
&pps->params.assert_off_tu);
|
|
|
|
/* Save the time stamp */
|
|
pps->assert_tu = ts_real;
|
|
pps->assert_sequence++;
|
|
dev_dbg(&pps->dev, "capture assert seq #%u\n",
|
|
pps->assert_sequence);
|
|
|
|
captured = ~0;
|
|
}
|
|
if (event & pps->params.mode & PPS_CAPTURECLEAR) {
|
|
/* We have to add an offset? */
|
|
if (pps->params.mode & PPS_OFFSETCLEAR)
|
|
pps_add_offset(&ts_real,
|
|
&pps->params.clear_off_tu);
|
|
|
|
/* Save the time stamp */
|
|
pps->clear_tu = ts_real;
|
|
pps->clear_sequence++;
|
|
dev_dbg(&pps->dev, "capture clear seq #%u\n",
|
|
pps->clear_sequence);
|
|
|
|
captured = ~0;
|
|
}
|
|
|
|
pps_kc_event(pps, ts, event);
|
|
|
|
/* Wake up if captured something */
|
|
if (captured) {
|
|
pps->last_ev++;
|
|
wake_up_interruptible_all(&pps->queue);
|
|
|
|
kill_fasync(&pps->async_queue, SIGIO, POLL_IN);
|
|
}
|
|
|
|
spin_unlock_irqrestore(&pps->lock, flags);
|
|
}
|
|
EXPORT_SYMBOL(pps_event);
|