2020-10-15 22:31:52 +00:00
|
|
|
package accounts
|
2020-08-11 23:15:06 +00:00
|
|
|
|
|
|
|
import (
|
|
|
|
"archive/zip"
|
2020-09-21 08:50:05 +00:00
|
|
|
"encoding/hex"
|
2020-08-11 23:15:06 +00:00
|
|
|
"encoding/json"
|
2022-04-18 20:42:07 +00:00
|
|
|
"io"
|
2020-08-11 23:15:06 +00:00
|
|
|
"os"
|
|
|
|
"path/filepath"
|
|
|
|
"sort"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
"time"
|
|
|
|
|
2024-02-15 05:46:47 +00:00
|
|
|
"github.com/prysmaticlabs/prysm/v5/config/params"
|
|
|
|
"github.com/prysmaticlabs/prysm/v5/io/file"
|
|
|
|
"github.com/prysmaticlabs/prysm/v5/testing/assert"
|
|
|
|
"github.com/prysmaticlabs/prysm/v5/testing/require"
|
|
|
|
"github.com/prysmaticlabs/prysm/v5/validator/accounts"
|
|
|
|
"github.com/prysmaticlabs/prysm/v5/validator/accounts/iface"
|
|
|
|
"github.com/prysmaticlabs/prysm/v5/validator/keymanager"
|
|
|
|
"github.com/prysmaticlabs/prysm/v5/validator/keymanager/derived"
|
|
|
|
constant "github.com/prysmaticlabs/prysm/v5/validator/testing"
|
2020-11-16 22:26:04 +00:00
|
|
|
)
|
|
|
|
|
2020-09-21 08:50:05 +00:00
|
|
|
func TestBackupAccounts_Noninteractive_Derived(t *testing.T) {
|
|
|
|
walletDir, _, passwordFilePath := setupWalletAndPasswordsDir(t)
|
2021-01-05 13:09:41 +00:00
|
|
|
// Specify the password locally to this file for convenience.
|
2020-09-21 08:50:05 +00:00
|
|
|
password := "Pa$sW0rD0__Fo0xPr"
|
2022-04-18 20:42:07 +00:00
|
|
|
require.NoError(t, os.WriteFile(passwordFilePath, []byte(password), os.ModePerm))
|
2020-09-21 08:50:05 +00:00
|
|
|
|
|
|
|
// Write a directory where we will backup accounts to.
|
2020-11-10 22:45:17 +00:00
|
|
|
backupDir := filepath.Join(t.TempDir(), "backupDir")
|
2020-11-09 20:27:03 +00:00
|
|
|
require.NoError(t, os.MkdirAll(backupDir, params.BeaconIoConfig().ReadWriteExecutePermissions))
|
2020-09-21 08:50:05 +00:00
|
|
|
|
|
|
|
// Write a password for the accounts we wish to backup to a file.
|
|
|
|
backupPasswordFile := filepath.Join(backupDir, "backuppass.txt")
|
2022-04-18 20:42:07 +00:00
|
|
|
err := os.WriteFile(
|
2020-09-21 08:50:05 +00:00
|
|
|
backupPasswordFile,
|
|
|
|
[]byte("Passw0rdz4938%%"),
|
|
|
|
params.BeaconIoConfig().ReadWritePermissions,
|
|
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
// We initialize a wallet with a derived keymanager.
|
|
|
|
cliCtx := setupWalletCtx(t, &testWalletConfig{
|
|
|
|
// Wallet configuration flags.
|
|
|
|
walletDir: walletDir,
|
2020-10-15 22:31:52 +00:00
|
|
|
keymanagerKind: keymanager.Derived,
|
2020-09-21 08:50:05 +00:00
|
|
|
walletPasswordFile: passwordFilePath,
|
|
|
|
// Flags required for BackupAccounts to work.
|
|
|
|
backupPasswordFile: backupPasswordFile,
|
|
|
|
backupDir: backupDir,
|
|
|
|
})
|
2022-09-02 14:56:47 +00:00
|
|
|
opts := []accounts.Option{
|
|
|
|
accounts.WithWalletDir(walletDir),
|
|
|
|
accounts.WithKeymanagerType(keymanager.Derived),
|
|
|
|
accounts.WithWalletPassword(password),
|
|
|
|
}
|
|
|
|
acc, err := accounts.NewCLIManager(opts...)
|
|
|
|
require.NoError(t, err)
|
|
|
|
w, err := acc.WalletCreate(cliCtx.Context)
|
2020-09-21 08:50:05 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
|
2021-02-24 18:05:46 +00:00
|
|
|
km, err := w.InitializeKeymanager(cliCtx.Context, iface.InitKeymanagerConfig{ListenForChanges: false})
|
2020-09-21 08:50:05 +00:00
|
|
|
require.NoError(t, err)
|
2020-11-16 22:26:04 +00:00
|
|
|
// Create 2 accounts
|
|
|
|
derivedKM, ok := km.(*derived.Keymanager)
|
|
|
|
require.Equal(t, true, ok)
|
2023-01-26 23:44:38 +00:00
|
|
|
err = derivedKM.RecoverAccountsFromMnemonic(cliCtx.Context, constant.TestMnemonic, derived.DefaultMnemonicLanguage, "", 2)
|
2020-09-21 08:50:05 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
// Obtain the public keys of the accounts we created
|
2020-10-15 22:31:52 +00:00
|
|
|
pubkeys, err := km.FetchValidatingPublicKeys(cliCtx.Context)
|
2020-09-21 08:50:05 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
var generatedPubKeys []string
|
|
|
|
for _, pubkey := range pubkeys {
|
|
|
|
encoded := make([]byte, hex.EncodedLen(len(pubkey)))
|
|
|
|
hex.Encode(encoded, pubkey[:])
|
|
|
|
generatedPubKeys = append(generatedPubKeys, string(encoded))
|
|
|
|
}
|
|
|
|
backupPublicKeys := strings.Join(generatedPubKeys, ",")
|
|
|
|
|
|
|
|
// Recreate a cliCtx with the addition of these backup keys to be later used by the backup process
|
|
|
|
cliCtx = setupWalletCtx(t, &testWalletConfig{
|
|
|
|
// Wallet configuration flags.
|
|
|
|
walletDir: walletDir,
|
2020-10-15 22:31:52 +00:00
|
|
|
keymanagerKind: keymanager.Derived,
|
2020-09-21 08:50:05 +00:00
|
|
|
walletPasswordFile: passwordFilePath,
|
|
|
|
// Flags required for BackupAccounts to work.
|
|
|
|
backupPublicKeys: backupPublicKeys,
|
|
|
|
backupPasswordFile: backupPasswordFile,
|
|
|
|
backupDir: backupDir,
|
|
|
|
})
|
|
|
|
|
|
|
|
// Next, we attempt to backup the accounts.
|
2022-06-07 15:19:12 +00:00
|
|
|
require.NoError(t, accountsBackup(cliCtx))
|
2020-09-21 08:50:05 +00:00
|
|
|
|
|
|
|
// We check a backup.zip file was created at the output path.
|
2022-06-07 15:19:12 +00:00
|
|
|
zipFilePath := filepath.Join(backupDir, accounts.ArchiveFilename)
|
Implement EIP-3076 minimal slashing protection, using a filesystem database (#13360)
* `EpochFromString`: Use already defined `Uint64FromString` function.
* `Test_uint64FromString` => `Test_FromString`
This test function tests more functions than `Uint64FromString`.
* Slashing protection history: Remove unreachable code.
The function `NewKVStore` creates, via `kv.UpdatePublicKeysBuckets`,
a new item in the `proposal-history-bucket-interchange`.
IMO there is no real reason to prefer `proposal` than `attestation`
as a prefix for this bucket, but this is the way it is done right now
and renaming the bucket will probably be backward incompatible.
An `attestedPublicKey` cannot exist without
the corresponding `proposedPublicKey`.
Thus, the `else` portion of code removed in this commit is not reachable.
We raise an error if we get there.
This is also probably the reason why the removed `else` portion was not
tested.
* `NewKVStore`: Switch items in `createBuckets`.
So the order corresponds to `schema.go`
* `slashableAttestationCheck`: Fix comments and logs.
* `ValidatorClient.db`: Use `iface.ValidatorDB`.
* BoltDB database: Implement `GraffitiFileHash`.
* Filesystem database: Creates `db.go`.
This file defines the following structs:
- `Store`
- `Graffiti`
- `Configuration`
- `ValidatorSlashingProtection`
This files implements the following public functions:
- `NewStore`
- `Close`
- `Backup`
- `DatabasePath`
- `ClearDB`
- `UpdatePublicKeysBuckets`
This files implements the following private functions:
- `slashingProtectionDirPath`
- `configurationFilePath`
- `configuration`
- `saveConfiguration`
- `validatorSlashingProtection`
- `saveValidatorSlashingProtection`
- `publicKeys`
* Filesystem database: Creates `genesis.go`.
This file defines the following public functions:
- `GenesisValidatorsRoot`
- `SaveGenesisValidatorsRoot`
* Filesystem database: Creates `graffiti.go`.
This file defines the following public functions:
- `SaveGraffitiOrderedIndex`
- `GraffitiOrderedIndex`
* Filesystem database: Creates `migration.go`.
This file defines the following public functions:
- `RunUpMigrations`
- `RunDownMigrations`
* Filesystem database: Creates proposer_settings.go.
This file defines the following public functions:
- `ProposerSettings`
- `ProposerSettingsExists`
- `SaveProposerSettings`
* Filesystem database: Creates `attester_protection.go`.
This file defines the following public functions:
- `EIPImportBlacklistedPublicKeys`
- `SaveEIPImportBlacklistedPublicKeys`
- `SigningRootAtTargetEpoch`
- `LowestSignedTargetEpoch`
- `LowestSignedSourceEpoch`
- `AttestedPublicKeys`
- `CheckSlashableAttestation`
- `SaveAttestationForPubKey`
- `SaveAttestationsForPubKey`
- `AttestationHistoryForPubKey`
* Filesystem database: Creates `proposer_protection.go`.
This file defines the following public functions:
- `HighestSignedProposal`
- `LowestSignedProposal`
- `ProposalHistoryForPubKey`
- `ProposalHistoryForSlot`
- `ProposedPublicKeys`
* Ensure that the filesystem store implements the `ValidatorDB` interface.
* `slashableAttestationCheck`: Check the database type.
* `slashableProposalCheck`: Check the database type.
* `slashableAttestationCheck`: Allow usage of minimal slashing protection.
* `slashableProposalCheck`: Allow usage of minimal slashing protection.
* `ImportStandardProtectionJSON`: Check the database type.
* `ImportStandardProtectionJSON`: Allow usage of min slashing protection.
* Implement `RecursiveDirFind`.
* Implement minimal<->complete DB conversion.
3 public functions are implemented:
- `IsCompleteDatabaseExisting`
- `IsMinimalDatabaseExisting`
- `ConvertDatabase`
* `setupDB`: Add `isSlashingProtectionMinimal` argument.
The feature addition is located in `validator/node/node_test.go`.
The rest of this commit consists in minimal slashing protection testing.
* `setupWithKey`: Add `isSlashingProtectionMinimal` argument.
The feature addition is located in `validator/client/propose_test.go`.
The rest of this commit consists in tests wrapping.
* `setup`: Add `isSlashingProtectionMinimal` argument.
The added feature is located in the `validator/client/propose_test.go`
file.
The rest of this commit consists in tests wrapping.
* `initializeFromCLI` and `initializeForWeb`: Factorize db init.
* Add `convert-complete-to-minimal` command.
* Creates `--enable-minimal-slashing-protection` flag.
* `importSlashingProtectionJSON`: Check database type.
* `exportSlashingProtectionJSON`: Check database type.
* `TestClearDB`: Test with minimal slashing protection.
* KeyManager: Test with minimal slashing protection.
* RPC: KeyManager: Test with minimal slashing protection.
* `convert-complete-to-minimal`: Change option names.
Options were:
- `--source` (for source data directory), and
- `--target` (for target data directory)
However, since this command deals with slashing protection, which has
source (epochs) and target (epochs), the initial option names may confuse
the user.
In this commit:
`--source` ==> `--source-data-dir`
`--target` ==> `--target-data-dir`
* Set `SlashableAttestationCheck` as an iface method.
And delete `CheckSlashableAttestation` from iface.
* Move helpers functions in a more general directory.
No functional change.
* Extract common structs out of `kv`.
==> `filesystem` does not depend anymore on `kv`.
==> `iface` does not depend anymore on `kv`.
==> `slashing-protection` does not depend anymore on `kv`.
* Move `ValidateMetadata` in `validator/helpers`.
* `ValidateMetadata`: Test with mock.
This way, we can:
- Avoid any circular import for tests.
- Implement once for all `iface.ValidatorDB` implementations
the `ValidateMetadata`function.
- Have tests (and coverage) of `ValidateMetadata`in
its own package.
The ideal solution would have been to implement `ValidateMetadata` as
a method with the `iface.ValidatorDB`receiver.
Unfortunately, golang does not allow that.
* `iface.ValidatorDB`: Implement ImportStandardProtectionJSON.
The whole purpose of this commit is to avoid the `switch validatorDB.(type)`
in `ImportStandardProtectionJSON`.
* `iface.ValidatorDB`: Implement `SlashableProposalCheck`.
* Remove now useless `slashableProposalCheck`.
* Delete useless `ImportStandardProtectionJSON`.
* `file.Exists`: Detect directories and return an error.
Before, `Exists` was only able to detect if a file exists.
Now, this function takes an extra `File` or `Directory` argument.
It detects either if a file or a directory exists.
Before, if an error was returned by `os.Stat`, the the file was
considered as non existing.
Now, it is treated as a real error.
* Replace `os.Stat` by `file.Exists`.
* Remove `Is{Complete,Minimal}DatabaseExisting`.
* `publicKeys`: Add log if unexpected file found.
* Move `{Source,Target}DataDirFlag`in `db.go`.
* `failedAttLocalProtectionErr`: `var`==> `const`
* `signingRoot`: `32`==> `fieldparams.RootLength`.
* `validatorClientData`==> `validator-client-data`.
To be consistent with `slashing-protection`.
* Add progress bars for `import` and `convert`.
* `parseBlocksForUniquePublicKeys`: Move in `db/kv`.
* helpers: Remove unused `initializeProgressBar` function.
2024-03-05 15:27:15 +00:00
|
|
|
fileExists, err := file.Exists(zipFilePath, file.Regular)
|
|
|
|
require.NoError(t, err, "could not check if backup file exists")
|
|
|
|
assert.Equal(t, true, fileExists, "backup file does not exist")
|
2020-09-21 08:50:05 +00:00
|
|
|
|
|
|
|
// We attempt to unzip the file and verify the keystores do match our accounts.
|
|
|
|
f, err := os.Open(zipFilePath)
|
|
|
|
require.NoError(t, err)
|
|
|
|
defer func() {
|
|
|
|
require.NoError(t, f.Close())
|
|
|
|
}()
|
|
|
|
fi, err := f.Stat()
|
|
|
|
require.NoError(t, err)
|
|
|
|
r, err := zip.NewReader(f, fi.Size())
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
// We check we have 2 keystore files in the unzipped results.
|
|
|
|
require.DeepEqual(t, 2, len(r.File))
|
|
|
|
unzippedPublicKeys := make([]string, 2)
|
|
|
|
for i, unzipped := range r.File {
|
|
|
|
ff, err := unzipped.Open()
|
|
|
|
require.NoError(t, err)
|
2022-04-18 20:42:07 +00:00
|
|
|
encodedBytes, err := io.ReadAll(ff)
|
2020-09-21 08:50:05 +00:00
|
|
|
require.NoError(t, err)
|
2020-10-15 22:31:52 +00:00
|
|
|
keystoreFile := &keymanager.Keystore{}
|
2020-09-21 08:50:05 +00:00
|
|
|
require.NoError(t, json.Unmarshal(encodedBytes, keystoreFile))
|
|
|
|
require.NoError(t, ff.Close())
|
|
|
|
unzippedPublicKeys[i] = keystoreFile.Pubkey
|
|
|
|
}
|
|
|
|
sort.Strings(unzippedPublicKeys)
|
|
|
|
sort.Strings(generatedPubKeys)
|
|
|
|
assert.DeepEqual(t, unzippedPublicKeys, generatedPubKeys)
|
|
|
|
}
|
|
|
|
|
2020-10-16 18:45:14 +00:00
|
|
|
func TestBackupAccounts_Noninteractive_Imported(t *testing.T) {
|
2020-08-11 23:15:06 +00:00
|
|
|
walletDir, _, passwordFilePath := setupWalletAndPasswordsDir(t)
|
|
|
|
// Write a directory where we will import keys from.
|
2020-11-10 22:45:17 +00:00
|
|
|
keysDir := filepath.Join(t.TempDir(), "keysDir")
|
2020-11-09 20:27:03 +00:00
|
|
|
require.NoError(t, os.MkdirAll(keysDir, params.BeaconIoConfig().ReadWriteExecutePermissions))
|
2020-08-11 23:15:06 +00:00
|
|
|
|
|
|
|
// Write a directory where we will backup accounts to.
|
2020-11-10 22:45:17 +00:00
|
|
|
backupDir := filepath.Join(t.TempDir(), "backupDir")
|
2020-11-09 20:27:03 +00:00
|
|
|
require.NoError(t, os.MkdirAll(backupDir, params.BeaconIoConfig().ReadWriteExecutePermissions))
|
2020-08-11 23:15:06 +00:00
|
|
|
|
|
|
|
// Create 2 keystore files in the keys directory we can then
|
|
|
|
// import from in our wallet.
|
|
|
|
k1, _ := createKeystore(t, keysDir)
|
|
|
|
time.Sleep(time.Second)
|
|
|
|
k2, _ := createKeystore(t, keysDir)
|
|
|
|
generatedPubKeys := []string{k1.Pubkey, k2.Pubkey}
|
|
|
|
backupPublicKeys := strings.Join(generatedPubKeys, ",")
|
|
|
|
|
|
|
|
// Write a password for the accounts we wish to backup to a file.
|
|
|
|
backupPasswordFile := filepath.Join(backupDir, "backuppass.txt")
|
2022-04-18 20:42:07 +00:00
|
|
|
err := os.WriteFile(
|
2020-08-11 23:15:06 +00:00
|
|
|
backupPasswordFile,
|
|
|
|
[]byte("Passw0rdz4938%%"),
|
|
|
|
params.BeaconIoConfig().ReadWritePermissions,
|
|
|
|
)
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
2020-10-16 18:45:14 +00:00
|
|
|
// We initialize a wallet with a imported keymanager.
|
2020-08-11 23:15:06 +00:00
|
|
|
cliCtx := setupWalletCtx(t, &testWalletConfig{
|
|
|
|
// Wallet configuration flags.
|
|
|
|
walletDir: walletDir,
|
2022-02-01 19:54:19 +00:00
|
|
|
keymanagerKind: keymanager.Local,
|
2020-08-11 23:15:06 +00:00
|
|
|
walletPasswordFile: passwordFilePath,
|
|
|
|
accountPasswordFile: passwordFilePath,
|
|
|
|
// Flags required for ImportAccounts to work.
|
|
|
|
keysDir: keysDir,
|
|
|
|
// Flags required for BackupAccounts to work.
|
|
|
|
backupPublicKeys: backupPublicKeys,
|
|
|
|
backupPasswordFile: backupPasswordFile,
|
|
|
|
backupDir: backupDir,
|
|
|
|
})
|
2022-09-02 14:56:47 +00:00
|
|
|
opts := []accounts.Option{
|
|
|
|
accounts.WithWalletDir(walletDir),
|
|
|
|
accounts.WithKeymanagerType(keymanager.Local),
|
|
|
|
accounts.WithWalletPassword(password),
|
|
|
|
}
|
|
|
|
acc, err := accounts.NewCLIManager(opts...)
|
|
|
|
require.NoError(t, err)
|
|
|
|
_, err = acc.WalletCreate(cliCtx.Context)
|
2020-08-11 23:15:06 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
// We attempt to import accounts we wrote to the keys directory
|
|
|
|
// into our newly created wallet.
|
2022-06-16 14:14:03 +00:00
|
|
|
require.NoError(t, accountsImport(cliCtx))
|
2020-08-11 23:15:06 +00:00
|
|
|
|
|
|
|
// Next, we attempt to backup the accounts.
|
2022-06-07 15:19:12 +00:00
|
|
|
require.NoError(t, accountsBackup(cliCtx))
|
2020-08-11 23:15:06 +00:00
|
|
|
|
|
|
|
// We check a backup.zip file was created at the output path.
|
2022-06-07 15:19:12 +00:00
|
|
|
zipFilePath := filepath.Join(backupDir, accounts.ArchiveFilename)
|
Implement EIP-3076 minimal slashing protection, using a filesystem database (#13360)
* `EpochFromString`: Use already defined `Uint64FromString` function.
* `Test_uint64FromString` => `Test_FromString`
This test function tests more functions than `Uint64FromString`.
* Slashing protection history: Remove unreachable code.
The function `NewKVStore` creates, via `kv.UpdatePublicKeysBuckets`,
a new item in the `proposal-history-bucket-interchange`.
IMO there is no real reason to prefer `proposal` than `attestation`
as a prefix for this bucket, but this is the way it is done right now
and renaming the bucket will probably be backward incompatible.
An `attestedPublicKey` cannot exist without
the corresponding `proposedPublicKey`.
Thus, the `else` portion of code removed in this commit is not reachable.
We raise an error if we get there.
This is also probably the reason why the removed `else` portion was not
tested.
* `NewKVStore`: Switch items in `createBuckets`.
So the order corresponds to `schema.go`
* `slashableAttestationCheck`: Fix comments and logs.
* `ValidatorClient.db`: Use `iface.ValidatorDB`.
* BoltDB database: Implement `GraffitiFileHash`.
* Filesystem database: Creates `db.go`.
This file defines the following structs:
- `Store`
- `Graffiti`
- `Configuration`
- `ValidatorSlashingProtection`
This files implements the following public functions:
- `NewStore`
- `Close`
- `Backup`
- `DatabasePath`
- `ClearDB`
- `UpdatePublicKeysBuckets`
This files implements the following private functions:
- `slashingProtectionDirPath`
- `configurationFilePath`
- `configuration`
- `saveConfiguration`
- `validatorSlashingProtection`
- `saveValidatorSlashingProtection`
- `publicKeys`
* Filesystem database: Creates `genesis.go`.
This file defines the following public functions:
- `GenesisValidatorsRoot`
- `SaveGenesisValidatorsRoot`
* Filesystem database: Creates `graffiti.go`.
This file defines the following public functions:
- `SaveGraffitiOrderedIndex`
- `GraffitiOrderedIndex`
* Filesystem database: Creates `migration.go`.
This file defines the following public functions:
- `RunUpMigrations`
- `RunDownMigrations`
* Filesystem database: Creates proposer_settings.go.
This file defines the following public functions:
- `ProposerSettings`
- `ProposerSettingsExists`
- `SaveProposerSettings`
* Filesystem database: Creates `attester_protection.go`.
This file defines the following public functions:
- `EIPImportBlacklistedPublicKeys`
- `SaveEIPImportBlacklistedPublicKeys`
- `SigningRootAtTargetEpoch`
- `LowestSignedTargetEpoch`
- `LowestSignedSourceEpoch`
- `AttestedPublicKeys`
- `CheckSlashableAttestation`
- `SaveAttestationForPubKey`
- `SaveAttestationsForPubKey`
- `AttestationHistoryForPubKey`
* Filesystem database: Creates `proposer_protection.go`.
This file defines the following public functions:
- `HighestSignedProposal`
- `LowestSignedProposal`
- `ProposalHistoryForPubKey`
- `ProposalHistoryForSlot`
- `ProposedPublicKeys`
* Ensure that the filesystem store implements the `ValidatorDB` interface.
* `slashableAttestationCheck`: Check the database type.
* `slashableProposalCheck`: Check the database type.
* `slashableAttestationCheck`: Allow usage of minimal slashing protection.
* `slashableProposalCheck`: Allow usage of minimal slashing protection.
* `ImportStandardProtectionJSON`: Check the database type.
* `ImportStandardProtectionJSON`: Allow usage of min slashing protection.
* Implement `RecursiveDirFind`.
* Implement minimal<->complete DB conversion.
3 public functions are implemented:
- `IsCompleteDatabaseExisting`
- `IsMinimalDatabaseExisting`
- `ConvertDatabase`
* `setupDB`: Add `isSlashingProtectionMinimal` argument.
The feature addition is located in `validator/node/node_test.go`.
The rest of this commit consists in minimal slashing protection testing.
* `setupWithKey`: Add `isSlashingProtectionMinimal` argument.
The feature addition is located in `validator/client/propose_test.go`.
The rest of this commit consists in tests wrapping.
* `setup`: Add `isSlashingProtectionMinimal` argument.
The added feature is located in the `validator/client/propose_test.go`
file.
The rest of this commit consists in tests wrapping.
* `initializeFromCLI` and `initializeForWeb`: Factorize db init.
* Add `convert-complete-to-minimal` command.
* Creates `--enable-minimal-slashing-protection` flag.
* `importSlashingProtectionJSON`: Check database type.
* `exportSlashingProtectionJSON`: Check database type.
* `TestClearDB`: Test with minimal slashing protection.
* KeyManager: Test with minimal slashing protection.
* RPC: KeyManager: Test with minimal slashing protection.
* `convert-complete-to-minimal`: Change option names.
Options were:
- `--source` (for source data directory), and
- `--target` (for target data directory)
However, since this command deals with slashing protection, which has
source (epochs) and target (epochs), the initial option names may confuse
the user.
In this commit:
`--source` ==> `--source-data-dir`
`--target` ==> `--target-data-dir`
* Set `SlashableAttestationCheck` as an iface method.
And delete `CheckSlashableAttestation` from iface.
* Move helpers functions in a more general directory.
No functional change.
* Extract common structs out of `kv`.
==> `filesystem` does not depend anymore on `kv`.
==> `iface` does not depend anymore on `kv`.
==> `slashing-protection` does not depend anymore on `kv`.
* Move `ValidateMetadata` in `validator/helpers`.
* `ValidateMetadata`: Test with mock.
This way, we can:
- Avoid any circular import for tests.
- Implement once for all `iface.ValidatorDB` implementations
the `ValidateMetadata`function.
- Have tests (and coverage) of `ValidateMetadata`in
its own package.
The ideal solution would have been to implement `ValidateMetadata` as
a method with the `iface.ValidatorDB`receiver.
Unfortunately, golang does not allow that.
* `iface.ValidatorDB`: Implement ImportStandardProtectionJSON.
The whole purpose of this commit is to avoid the `switch validatorDB.(type)`
in `ImportStandardProtectionJSON`.
* `iface.ValidatorDB`: Implement `SlashableProposalCheck`.
* Remove now useless `slashableProposalCheck`.
* Delete useless `ImportStandardProtectionJSON`.
* `file.Exists`: Detect directories and return an error.
Before, `Exists` was only able to detect if a file exists.
Now, this function takes an extra `File` or `Directory` argument.
It detects either if a file or a directory exists.
Before, if an error was returned by `os.Stat`, the the file was
considered as non existing.
Now, it is treated as a real error.
* Replace `os.Stat` by `file.Exists`.
* Remove `Is{Complete,Minimal}DatabaseExisting`.
* `publicKeys`: Add log if unexpected file found.
* Move `{Source,Target}DataDirFlag`in `db.go`.
* `failedAttLocalProtectionErr`: `var`==> `const`
* `signingRoot`: `32`==> `fieldparams.RootLength`.
* `validatorClientData`==> `validator-client-data`.
To be consistent with `slashing-protection`.
* Add progress bars for `import` and `convert`.
* `parseBlocksForUniquePublicKeys`: Move in `db/kv`.
* helpers: Remove unused `initializeProgressBar` function.
2024-03-05 15:27:15 +00:00
|
|
|
exists, err := file.Exists(zipFilePath, file.Regular)
|
|
|
|
require.NoError(t, err, "could not check if backup file exists")
|
|
|
|
assert.Equal(t, true, exists, "backup file does not exist")
|
2020-08-11 23:15:06 +00:00
|
|
|
|
|
|
|
// We attempt to unzip the file and verify the keystores do match our accounts.
|
|
|
|
f, err := os.Open(zipFilePath)
|
|
|
|
require.NoError(t, err)
|
|
|
|
defer func() {
|
|
|
|
require.NoError(t, f.Close())
|
|
|
|
}()
|
|
|
|
fi, err := f.Stat()
|
|
|
|
require.NoError(t, err)
|
|
|
|
r, err := zip.NewReader(f, fi.Size())
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
// We check we have 2 keystore files in the unzipped results.
|
|
|
|
require.DeepEqual(t, 2, len(r.File))
|
|
|
|
unzippedPublicKeys := make([]string, 2)
|
|
|
|
for i, unzipped := range r.File {
|
|
|
|
ff, err := unzipped.Open()
|
|
|
|
require.NoError(t, err)
|
2022-04-18 20:42:07 +00:00
|
|
|
encodedBytes, err := io.ReadAll(ff)
|
2020-08-11 23:15:06 +00:00
|
|
|
require.NoError(t, err)
|
2020-10-15 22:31:52 +00:00
|
|
|
keystoreFile := &keymanager.Keystore{}
|
2020-08-11 23:15:06 +00:00
|
|
|
require.NoError(t, json.Unmarshal(encodedBytes, keystoreFile))
|
|
|
|
require.NoError(t, ff.Close())
|
|
|
|
unzippedPublicKeys[i] = keystoreFile.Pubkey
|
|
|
|
}
|
|
|
|
sort.Strings(unzippedPublicKeys)
|
|
|
|
sort.Strings(generatedPubKeys)
|
|
|
|
assert.DeepEqual(t, unzippedPublicKeys, generatedPubKeys)
|
|
|
|
}
|