mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-21 11:10:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Optimize Adding Dirty Indices (#13660)

Browse Source 
* add it in

* add in test

* potuz's review
This commit is contained in:
Nishant Das 2024-02-24 18:08:17 +08:00 committed by GitHub
parent 70e1b11aeb
commit 1d5a09c05d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
beacon-chain/state/state-native/setters_misc.go
View File

@ -6,6 +6,7 @@ import (
"github.com/prysmaticlabs/prysm/v5/beacon-chain/state/stateutil"
fieldparams "github.com/prysmaticlabs/prysm/v5/config/fieldparams"
"github.com/prysmaticlabs/prysm/v5/consensus-types/primitives"
"github.com/prysmaticlabs/prysm/v5/container/slice"
"github.com/prysmaticlabs/prysm/v5/crypto/hash"
"github.com/prysmaticlabs/prysm/v5/encoding/bytesutil"
ethpb "github.com/prysmaticlabs/prysm/v5/proto/prysm/v1alpha1"
@ -198,9 +199,14 @@ func (b *BeaconState) addDirtyIndices(index types.FieldIndex, indices []uint64)
return
}
totalIndicesLen := len(b.dirtyIndices[index]) + len(indices)
// Reduce duplicates to verify that these are indeed unique.
if totalIndicesLen > indicesLimit {
b.dirtyIndices[index] = slice.SetUint64(b.dirtyIndices[index])
totalIndicesLen = len(b.dirtyIndices[index]) + len(indices)
}
if totalIndicesLen > indicesLimit {
b.rebuildTrie[index] = true
b.dirtyIndices[index] = []uint64{}
b.dirtyIndices[index] = make([]uint64, 0, indicesLimit)
} else {
b.dirtyIndices[index] = append(b.dirtyIndices[index], indices...)
}

20
beacon-chain/state/state-native/state_test.go
View File

@ -416,6 +416,26 @@ func TestCopyAllTries(t *testing.T) {
assert.NotEqual(t, rt, newRt)
}
func TestDuplicateDirtyIndices(t *testing.T) {
newState := &BeaconState{
rebuildTrie: make(map[types.FieldIndex]bool),
dirtyIndices: make(map[types.FieldIndex][]uint64),
}
for i := uint64(0); i < indicesLimit-5; i++ {
newState.dirtyIndices[types.Balances] = append(newState.dirtyIndices[types.Balances], i)
}
// Append duplicates
newState.dirtyIndices[types.Balances] = append(newState.dirtyIndices[types.Balances], []uint64{0, 1, 2, 3, 4}...)
// We would remove the duplicates and stay under the threshold
newState.addDirtyIndices(types.Balances, []uint64{9997, 9998})
assert.Equal(t, false, newState.rebuildTrie[types.Balances])
// We would trigger above the threshold.
newState.addDirtyIndices(types.Balances, []uint64{10000, 10001, 10002, 10003})
assert.Equal(t, true, newState.rebuildTrie[types.Balances])
}
func generateState(t *testing.T) state.BeaconState {
count := uint64(100)
vals := make([]*ethpb.Validator, 0, count)

2
container/slice/slice.go
View File

@ -94,7 +94,7 @@ func UnionUint64(s ...[]uint64) []uint64 {
// values from the provided list of indices.
func SetUint64(a []uint64) []uint64 {
// Remove duplicates indices.
intMap := map[uint64]bool{}
intMap := make(map[uint64]bool, len(a))
cleanedIndices := make([]uint64, 0, len(a))
for _, idx := range a {
if intMap[idx] {