mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-25 12:57:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Invert Update Head Timely Flag (#9224)

Browse Source 
* invert

* Update shared/featureconfig/flags.go

Co-authored-by: Radosław Kapka <rkapka@wp.pl>

Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
This commit is contained in:
Nishant Das 2021-07-20 01:23:43 +08:00 committed by GitHub
parent 1beb0071b5
commit 40a96bc2b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
shared/featureconfig/config.go
View File

@ -183,9 +183,10 @@ func ConfigureBeaconChain(ctx *cli.Context) {
log.WithField(enableNextSlotStateCache.Name, enableNextSlotStateCache.Usage).Warn(enabledFeatureFlag)
cfg.EnableNextSlotStateCache = true
}
if ctx.Bool(updateHeadTimely.Name) {
log.WithField(updateHeadTimely.Name, updateHeadTimely.Usage).Warn(enabledFeatureFlag)
cfg.UpdateHeadTimely = true
cfg.UpdateHeadTimely = true
if ctx.Bool(disableUpdateHeadTimely.Name) {
log.WithField(disableUpdateHeadTimely.Name, disableUpdateHeadTimely.Usage).Warn(enabledFeatureFlag)
cfg.UpdateHeadTimely = false
}
cfg.ProposerAttsSelectionUsingMaxCover = true
if ctx.Bool(disableProposerAttsSelectionUsingMaxCover.Name) {

6
shared/featureconfig/deprecated_flags.go
View File

@ -42,6 +42,11 @@ var (
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedUpdateHeadTimely = &cli.BoolFlag{
Name: "update-head-timely",
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedEnableOptimizedBalanceUpdate = &cli.BoolFlag{
Name: "enable-optimized-balance-update",
Usage: deprecatedUsage,
@ -58,4 +63,5 @@ var deprecatedFlags = []cli.Flag{
deprecatedDisableBlst,
deprecatedProposerAttsSelectionUsingMaxCover,
deprecatedEnableOptimizedBalanceUpdate,
deprecatedUpdateHeadTimely,
}

9
shared/featureconfig/flags.go
View File

@ -106,9 +106,9 @@ var (
Name: "enable-next-slot-state-cache",
Usage: "Improves attesting and proposing efficiency by caching the next slot state at the end of the current slot",
}
updateHeadTimely = &cli.BoolFlag{
Name: "update-head-timely",
Usage: "Improves update head time by updating head right after state transition",
disableUpdateHeadTimely = &cli.BoolFlag{
Name: "disable-update-head-timely",
Usage: "Disables updating head right after state transition",
}
disableProposerAttsSelectionUsingMaxCover = &cli.BoolFlag{
Name: "disable-proposer-atts-selection-using-max-cover",
@ -135,7 +135,6 @@ var devModeFlags = []cli.Flag{
enableLargerGossipHistory,
enableNextSlotStateCache,
forceOptMaxCoverAggregationStategy,
updateHeadTimely,
}
// ValidatorFlags contains a list of all the feature flags that apply to the validator client.
@ -185,7 +184,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
disableBroadcastSlashingFlag,
enableNextSlotStateCache,
forceOptMaxCoverAggregationStategy,
updateHeadTimely,
disableUpdateHeadTimely,
disableProposerAttsSelectionUsingMaxCover,
disableOptimizedBalanceUpdate,
}...)