mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-22 19:40:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Accept block when error is only in logging (#13223)

Browse Source 
* Accept block when error is only in logging

* linter shutup

* ignore nilerr on the linter
This commit is contained in:
Potuz 2023-11-24 16:00:53 -03:00 committed by GitHub
parent 6c85587d14
commit 67d0b26a21
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
beacon-chain/sync/validate_beacon_blocks.go
View File

@ -202,25 +202,25 @@ func (s *Service) validateBeaconBlockPubSub(ctx context.Context, pid peer.ID, ms
msg.ValidatorData = blkPb // Used in downstream subscriber
// Log the arrival time of the accepted block
startTime, err := slots.ToTime(genesisTime, blk.Block().Slot())
if err != nil {
return pubsub.ValidationIgnore, err
}
graffiti := blk.Block().Body().Graffiti()
startTime, err := slots.ToTime(genesisTime, blk.Block().Slot())
logFields := logrus.Fields{
"blockSlot": blk.Block().Slot(),
"proposerIndex": blk.Block().ProposerIndex(),
"graffiti": string(graffiti[:]),
}
if err != nil {
log.WithError(err).WithFields(logFields).Warn("Received block, could not report timing information.")
return pubsub.ValidationAccept, nil
}
sinceSlotStartTime := receivedTime.Sub(startTime)
validationTime := prysmTime.Now().Sub(receivedTime)
log.WithFields(logrus.Fields{
"blockSlot": blk.Block().Slot(),
"sinceSlotStartTime": sinceSlotStartTime,
"validationTime": validationTime,
"proposerIndex": blk.Block().ProposerIndex(),
"graffiti": string(graffiti[:]),
}).Debug("Received block")
logFields["sinceSlotStartTime"] = sinceSlotStartTime
logFields["validationTime"] = validationTime
log.WithFields(logFields).Debug("Received block")
blockArrivalGossipSummary.Observe(float64(sinceSlotStartTime))
blockVerificationGossipSummary.Observe(float64(validationTime))
return pubsub.ValidationAccept, nil
}