mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-25 12:57:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix max churn bug (#2121)

Browse Source
This commit is contained in:
Preston Van Loon 2019-03-31 11:47:38 -05:00 committed by Nishant Das
parent 02f9a56513
commit 6b3df2f776
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
beacon-chain/core/validators/validator.go
View File

@ -529,7 +529,7 @@ func allValidatorsIndices(state *pb.BeaconState) []uint64 {
// MAX_DEPOSIT_AMOUNT, // MAX_DEPOSIT_AMOUNT,
// total_balance // (2 * MAX_BALANCE_CHURN_QUOTIENT)) // total_balance // (2 * MAX_BALANCE_CHURN_QUOTIENT))
func maxBalanceChurn(totalBalance uint64) uint64 { func maxBalanceChurn(totalBalance uint64) uint64 {
maxBalanceChurn := totalBalance / 2 * params.BeaconConfig().MaxBalanceChurnQuotient maxBalanceChurn := totalBalance / (2 * params.BeaconConfig().MaxBalanceChurnQuotient)
if maxBalanceChurn > params.BeaconConfig().MaxDepositAmount { if maxBalanceChurn > params.BeaconConfig().MaxDepositAmount {
return maxBalanceChurn return maxBalanceChurn
} }

9
beacon-chain/core/validators/validator_test.go
View File

@ -586,14 +586,15 @@ func TestUpdateRegistry_Exits(t *testing.T) {
} }
func TestMaxBalanceChurn_OK(t *testing.T) { func TestMaxBalanceChurn_OK(t *testing.T) {
maxDepositAmount := params.BeaconConfig().MaxDepositAmount
tests := []struct { tests := []struct {
totalBalance uint64 totalBalance uint64
maxBalanceChurn uint64 maxBalanceChurn uint64
}{ }{
{totalBalance: 1e9, maxBalanceChurn: params.BeaconConfig().MaxDepositAmount}, {totalBalance: 1e9, maxBalanceChurn: maxDepositAmount},
{totalBalance: params.BeaconConfig().MaxDepositAmount, maxBalanceChurn: 512 * 1e9}, {totalBalance: maxDepositAmount, maxBalanceChurn: maxDepositAmount},
{totalBalance: params.BeaconConfig().MaxDepositAmount * 10, maxBalanceChurn: 512 * 1e10}, {totalBalance: maxDepositAmount * 10, maxBalanceChurn: maxDepositAmount},
{totalBalance: params.BeaconConfig().MaxDepositAmount * 1000, maxBalanceChurn: 512 * 1e12}, {totalBalance: params.BeaconConfig().MaxDepositAmount * 1000, maxBalanceChurn: 5 * 1e11},
} }
for _, tt := range tests { for _, tt := range tests {