Update Travis (#2215)

* update travis

* update binutils

* upgrade binutils version

* remove cache

* none of this works

* upgrade ubuntu version

* lint fixes

.travis.yml

@@ -4,7 +4,8 @@ sudo: false
 matrix:
   include:
     - os: linux
-      go: 1.11.x
+      dist: xenial
+      go: 1.12.x
       env:
         - lint
       install:

beacon-chain/core/epoch/epoch_processing.go

@@ -125,7 +125,6 @@ func ProcessJustification(
 	prevEpochBoundaryAttestingBalance uint64,
 	prevTotalBalance uint64,
 	totalBalance uint64,
-	enableLogging bool,
 ) *pb.BeaconState {
 
 	ctx, span := trace.StartSpan(ctx, "beacon-chain.ChainService.state.ProcessEpoch.ProcessJustification")

beacon-chain/core/epoch/epoch_processing_test.go

@@ -229,7 +229,6 @@ func TestProcessJustification_PreviousEpochJustified(t *testing.T) {
 		1,
 		1,
 		1,
-		false, /* disable logging */
 	)
 
 	if newState.PreviousJustifiedEpoch != 3 {
@@ -256,7 +255,6 @@ func TestProcessJustification_PreviousEpochJustified(t *testing.T) {
 		1,
 		1,
 		1,
-		false, /* disable logging */
 	)
 	if newState.JustifiedEpoch != helpers.CurrentEpoch(state)-1 {
 		t.Errorf("New state's justified epoch %d != state's epoch -2: %d",

beacon-chain/core/state/transition.go

@@ -270,7 +270,6 @@ func ProcessEpoch(ctx context.Context, state *pb.BeaconState, config *Transition
 		prevEpochAttestingBalance,
 		prevTotalBalance,
 		totalBalance,
-		config.Logging,
 	)
 
 	// Process crosslinks records.

beacon-chain/db/state.go

@@ -5,6 +5,7 @@ import (
 	"encoding/binary"
 	"errors"
 	"fmt"
+
 	"github.com/boltdb/bolt"
 	"github.com/gogo/protobuf/proto"
 	"github.com/prometheus/client_golang/prometheus"

shared/prometheus/service.go

@@ -74,9 +74,11 @@ func (s *Service) healthzHandler(w http.ResponseWriter, _ *http.Request) {
 	}
 }
 
-func (s *Service) goroutinezHandler(w http.ResponseWriter, r *http.Request) {
+func (s *Service) goroutinezHandler(w http.ResponseWriter, _ *http.Request) {
 	stack := debug.Stack()
+	// #nosec G104
 	w.Write(stack)
+	// #nosec G104
 	pprof.Lookup("goroutine").WriteTo(w, 2)
 }