Remove disable ssz cache feature flag (#7513)

* Remove ssz cache flag and usages

* Fix TestBeaconState_ProtoBeaconStateCompatibility

* gazelle

* Add cache flag back for tests

* Revert previous changes

* Revert previous changes

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
This commit is contained in:
terence tsao 2020-10-13 20:13:59 -07:00 committed by GitHub
parent b9844024b4
commit 7de161e917
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 10 deletions

View File

@ -180,11 +180,9 @@ func ConfigureBeaconChain(ctx *cli.Context) {
log.Warn("Disabled dynamic attestation committee subnets") log.Warn("Disabled dynamic attestation committee subnets")
cfg.DisableDynamicCommitteeSubnets = true cfg.DisableDynamicCommitteeSubnets = true
} }
cfg.EnableSSZCache = true cfg.EnableSSZCache = true
if ctx.Bool(disableSSZCache.Name) {
log.Warn("Disabled ssz cache")
cfg.EnableSSZCache = false
}
if ctx.Bool(enableBackupWebhookFlag.Name) { if ctx.Bool(enableBackupWebhookFlag.Name) {
log.Warn("Allowing database backups to be triggered from HTTP webhook.") log.Warn("Allowing database backups to be triggered from HTTP webhook.")
cfg.EnableBackupWebhook = true cfg.EnableBackupWebhook = true

View File

@ -53,11 +53,6 @@ var (
Name: "disable-fork-choice-unsafe", Name: "disable-fork-choice-unsafe",
Usage: "UNSAFE: disable fork choice for determining head of the beacon chain.", Usage: "UNSAFE: disable fork choice for determining head of the beacon chain.",
} }
// disableSSZCache see https://github.com/prysmaticlabs/prysm/pull/4558.
disableSSZCache = &cli.BoolFlag{
Name: "disable-ssz-cache",
Usage: "Disable ssz state root cache mechanism.",
}
enableBackupWebhookFlag = &cli.BoolFlag{ enableBackupWebhookFlag = &cli.BoolFlag{
Name: "enable-db-backup-webhook", Name: "enable-db-backup-webhook",
Usage: "Serve HTTP handler to initiate database backups. The handler is served on the monitoring port at path /db/backup.", Usage: "Serve HTTP handler to initiate database backups. The handler is served on the monitoring port at path /db/backup.",
@ -225,7 +220,6 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{
writeSSZStateTransitionsFlag, writeSSZStateTransitionsFlag,
disableForkChoiceUnsafeFlag, disableForkChoiceUnsafeFlag,
disableDynamicCommitteeSubnets, disableDynamicCommitteeSubnets,
disableSSZCache,
kafkaBootstrapServersFlag, kafkaBootstrapServersFlag,
enableBackupWebhookFlag, enableBackupWebhookFlag,
cacheFilteredBlockTreeFlag, cacheFilteredBlockTreeFlag,