mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2025-01-12 04:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix fillInMissingBlocks (#11353)

Browse Source 
* Fix fillInMissingBlocks

Only check that the chain's parent is in forkchoice, rather than it
being the finalized checkpoint. Forkchoice anyway guarantees that the
chain will be a descendant of the finalized checkpoint.

* ensure root is not zero

* fix tests

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
This commit is contained in:
Potuz 2022-09-01 11:40:32 -03:00 committed by GitHub
parent c4deb84012
commit 84bc8f3d64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
beacon-chain/blockchain/process_block_helpers.go
View File

@ -277,7 +277,7 @@ func (s *Service) fillInForkChoiceMissingBlocks(ctx context.Context, blk interfa
if len(pendingNodes) == 1 { if len(pendingNodes) == 1 {
return nil return nil
} }
if root != s.ensureRootNotZeros(finalized.Root) { if root != s.ensureRootNotZeros(finalized.Root) && !s.ForkChoicer().HasNode(root) {
return errNotDescendantOfFinalized return errNotDescendantOfFinalized
} }
return s.cfg.ForkChoiceStore.InsertOptimisticChain(ctx, pendingNodes) return s.cfg.ForkChoiceStore.InsertOptimisticChain(ctx, pendingNodes)