mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2025-01-18 15:54:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Data Race on the background FCU call (#13602)

Browse Source
This commit is contained in:
Potuz 2024-02-13 13:22:53 -03:00 committed by GitHub
parent 3d13c69ef3
commit 8a89173937
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
beacon-chain/blockchain/forkchoice_update_execution.go
View File

@ -73,6 +73,8 @@ func (s *Service) sendFCUWithAttributes(cfg *postBlockProcessConfig, fcuArgs *fc
slotCtx, cancel := context.WithTimeout(context.Background(), slotDeadline) slotCtx, cancel := context.WithTimeout(context.Background(), slotDeadline)
defer cancel() defer cancel()
cfg.ctx = slotCtx cfg.ctx = slotCtx
s.cfg.ForkChoiceStore.RLock()
defer s.cfg.ForkChoiceStore.RUnlock()
if err := s.computePayloadAttributes(cfg, fcuArgs); err != nil { if err := s.computePayloadAttributes(cfg, fcuArgs); err != nil {
log.WithError(err).Error("could not compute payload attributes") log.WithError(err).Error("could not compute payload attributes")
return return
@ -80,8 +82,6 @@ func (s *Service) sendFCUWithAttributes(cfg *postBlockProcessConfig, fcuArgs *fc
if fcuArgs.attributes.IsEmpty() { if fcuArgs.attributes.IsEmpty() {
return return
} }
s.cfg.ForkChoiceStore.RLock()
defer s.cfg.ForkChoiceStore.RUnlock()
if _, err := s.notifyForkchoiceUpdate(cfg.ctx, fcuArgs); err != nil { if _, err := s.notifyForkchoiceUpdate(cfg.ctx, fcuArgs); err != nil {
log.WithError(err).Error("could not update forkchoice with payload attributes for proposal") log.WithError(err).Error("could not update forkchoice with payload attributes for proposal")
} }