mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-25 21:07:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve sorted indices check in blocks package (#3060)

Browse Source
This commit is contained in:
Justin Page 2019-07-23 18:17:47 -07:00 committed by terence tsao
parent 41e55a6902
commit 9d0e9fa77d
1 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
beacon-chain/core/blocks/block_operations.go
View File

@ -5,7 +5,6 @@ import (
"encoding/binary"
"errors"
"fmt"
"reflect"
"sort"
"github.com/gogo/protobuf/proto"
@ -697,24 +696,20 @@ func VerifyIndexedAttestation(beaconState *pb.BeaconState, indexedAtt *ethpb.Ind
return fmt.Errorf("expected disjoint indices intersection, received %v", custodyBitIntersection)
}
copiedBit0Indices := make([]uint64, len(custodyBit0Indices))
copy(copiedBit0Indices, custodyBit0Indices)
sort.SliceStable(copiedBit0Indices, func(i, j int) bool {
return copiedBit0Indices[i] < copiedBit0Indices[j]
custodyBit0IndicesIsSorted := sort.SliceIsSorted(custodyBit0Indices, func(i, j int) bool {
return custodyBit0Indices[i] < custodyBit0Indices[j]
})
if !reflect.DeepEqual(copiedBit0Indices, custodyBit0Indices) {
return fmt.Errorf("custody Bit0 indices are not sorted, wanted %v but got %v", copiedBit0Indices, custodyBit0Indices)
if !custodyBit0IndicesIsSorted {
return fmt.Errorf("custody Bit0 indices are not sorted, got %v", custodyBit0Indices)
}
copiedBit1Indices := make([]uint64, len(custodyBit1Indices))
copy(copiedBit1Indices, custodyBit1Indices)
sort.SliceStable(copiedBit1Indices, func(i, j int) bool {
return copiedBit1Indices[i] < copiedBit1Indices[j]
custodyBit1IndicesIsSorted := sort.SliceIsSorted(custodyBit1Indices, func(i, j int) bool {
return custodyBit1Indices[i] < custodyBit1Indices[j]
})
if len(custodyBit1Indices) > 0 && !reflect.DeepEqual(copiedBit1Indices, custodyBit1Indices) {
return fmt.Errorf("custody Bit1 indices are not sorted, wanted %v but got %v", copiedBit1Indices, custodyBit1Indices)
if !custodyBit1IndicesIsSorted {
return fmt.Errorf("custody Bit1 indices are not sorted, got %v", custodyBit1Indices)
}
if verifySignatures {