mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-24 20:37:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Do not propose a block when compute state root fails (#1972)

Browse Source
This commit is contained in:
Preston Van Loon 2019-03-12 12:49:09 -04:00 committed by GitHub
parent c320877dea
commit a7a22856f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
validator/client/validator_propose.go
View File

@ -110,7 +110,8 @@ func (v *validator) ProposeBlock(ctx context.Context, slot uint64) {
if err != nil {
log.WithField(
"block", proto.MarshalTextString(block),
).Errorf("Unable to compute state root: %v", err)
).Errorf("Not proposing! Unable to compute state root: %v", err)
return
}
block.StateRootHash32 = resp.GetStateRoot()

5
validator/client/validator_propose_test.go
View File

@ -354,11 +354,6 @@ func TestProposeBlock_ComputeStateFailure(t *testing.T) {
gomock.AssignableToTypeOf(&pb.PendingAttestationsRequest{}),
).Return(&pb.PendingAttestationsResponse{PendingAttestations: []*pbp2p.Attestation{}}, nil)
m.proposerClient.EXPECT().ProposeBlock(
gomock.Any(), // ctx
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Return(&pb.ProposeResponse{}, nil /*error*/)
m.proposerClient.EXPECT().ComputeStateRoot(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),