diff --git a/BUILD.bazel b/BUILD.bazel index 1dd28f288..60908f04c 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -68,7 +68,7 @@ nogo( "@org_golang_x_tools//go/analysis/passes/pkgfact:go_tool_library", "@org_golang_x_tools//go/analysis/passes/nilness:go_tool_library", "@org_golang_x_tools//go/analysis/passes/nilfunc:go_tool_library", - "@org_golang_x_tools//go/analysis/passes/lostcancel:go_tool_library", + # "@org_golang_x_tools//go/analysis/passes/lostcancel:go_tool_library", "@org_golang_x_tools//go/analysis/passes/loopclosure:go_tool_library", "@org_golang_x_tools//go/analysis/passes/httpresponse:go_tool_library", "@org_golang_x_tools//go/analysis/passes/findcall:go_tool_library", diff --git a/nogo_config.json b/nogo_config.json index d971abecf..2faae18d2 100644 --- a/nogo_config.json +++ b/nogo_config.json @@ -10,6 +10,11 @@ "external/*": "Unreachable third party code" } }, + "lostcancel": { + "exclude_files": { + "validator/client/runner.go": "No need to cancel right when goroutines begin" + } + }, "nilness": { "exclude_files": { "external/*": "Third party code" @@ -44,6 +49,5 @@ "exclude_files": { "external/*": "Third party code" } - } } diff --git a/validator/client/runner.go b/validator/client/runner.go index 83a804984..fda25f50c 100644 --- a/validator/client/runner.go +++ b/validator/client/runner.go @@ -100,7 +100,6 @@ func run(ctx context.Context, v Validator) { }(role, id) } - cancel() } } }