mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2024-12-25 12:57:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert removal of state root computation (#2168)

Browse Source 
* Revert "disable state root computation"

This reverts commit ba7368ac57f3ecd3cb710049e677ba60a820dd82.

* Revert "tests fixed"

This reverts commit 1141af27c253ca000de0a63f0e1c91d983078ebc.

* Fix build, skip test until https://github.com/prysmaticlabs/prysm/issues/2167
This commit is contained in:
Preston Van Loon 2019-04-05 09:58:33 -05:00 committed by GitHub
parent d19775dff9
commit e94838e9ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 172 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
validator/client/BUILD.bazel
View File

@ -21,6 +21,7 @@ go_library(
"//shared/keystore:go_default_library",
"//shared/params:go_default_library",
"//shared/slotutil:go_default_library",
"@com_github_gogo_protobuf//proto:go_default_library",
"@com_github_gogo_protobuf//types:go_default_library",
"@com_github_sirupsen_logrus//:go_default_library",
"@io_opencensus_go//plugin/ocgrpc:go_default_library",

1
validator/client/validator.go
View File

@ -135,6 +135,7 @@ func (v *validator) SlotDeadline(slot uint64) time.Time {
// beginning of a new epoch.
func (v *validator) UpdateAssignments(ctx context.Context, slot uint64) error {
// Testing run time for fetching every slot. This is not meant for production!
// https://github.com/prysmaticlabs/prysm/issues/2167
if slot%params.BeaconConfig().SlotsPerEpoch != 0 && v.assignment != nil && false {
// Do nothing if not epoch start AND assignments already exist.
return nil

10
validator/client/validator_propose.go
View File

@ -6,6 +6,7 @@ import (
"encoding/binary"
"fmt"
"github.com/gogo/protobuf/proto"
ptypes "github.com/gogo/protobuf/types"
pbp2p "github.com/prysmaticlabs/prysm/proto/beacon/p2p/v1"
pb "github.com/prysmaticlabs/prysm/proto/beacon/rpc/v1"
@ -106,7 +107,14 @@ func (v *validator) ProposeBlock(ctx context.Context, slot uint64) {
}
// 3. Compute state root transition from parent block to the new block.
block.StateRootHash32 = []byte("root")
resp, err := v.proposerClient.ComputeStateRoot(ctx, block)
if err != nil {
log.WithField(
"block", proto.MarshalTextString(block),
).Errorf("Not proposing! Unable to compute state root: %v", err)
return
}
block.StateRootHash32 = resp.GetStateRoot()
// 4. Sign the complete block.
// TODO(1366): BLS sign block

130
validator/client/validator_propose_test.go
View File

@ -124,6 +124,13 @@ func TestProposeBlock_UsePendingDeposits(t *testing.T) {
gomock.AssignableToTypeOf(&pb.PendingAttestationsRequest{}),
).Return(&pb.PendingAttestationsResponse{PendingAttestations: []*pbp2p.Attestation{}}, nil)
m.proposerClient.EXPECT().ComputeStateRoot(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Return(&pb.StateRootResponse{
StateRoot: []byte{'F'},
}, nil /*err*/)
var broadcastedBlock *pbp2p.BeaconBlock
m.proposerClient.EXPECT().ProposeBlock(
gomock.Any(), // context
@ -199,6 +206,13 @@ func TestProposeBlock_UsesEth1Data(t *testing.T) {
gomock.AssignableToTypeOf(&pb.PendingAttestationsRequest{}),
).Return(&pb.PendingAttestationsResponse{PendingAttestations: []*pbp2p.Attestation{}}, nil)
m.proposerClient.EXPECT().ComputeStateRoot(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Return(&pb.StateRootResponse{
StateRoot: []byte{'F'},
}, nil /*err*/)
var broadcastedBlock *pbp2p.BeaconBlock
m.proposerClient.EXPECT().ProposeBlock(
gomock.Any(), // ctx
@ -253,6 +267,13 @@ func TestProposeBlock_PendingAttestations_UsesCurrentSlot(t *testing.T) {
return &pb.PendingAttestationsResponse{PendingAttestations: []*pbp2p.Attestation{}}, nil
})
m.proposerClient.EXPECT().ComputeStateRoot(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Return(&pb.StateRootResponse{
StateRoot: []byte{'F'},
}, nil /*err*/)
m.proposerClient.EXPECT().ProposeBlock(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
@ -308,6 +329,108 @@ func TestProposeBlock_PendingAttestationsFailure(t *testing.T) {
testutil.AssertLogsContain(t, hook, "Failed to fetch pending attestations")
}
func TestProposeBlock_ComputeStateFailure(t *testing.T) {
hook := logTest.NewGlobal()
validator, m, finish := setup(t)
defer finish()
m.beaconClient.EXPECT().CanonicalHead(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pbp2p.BeaconBlock{}, nil /*err*/)
m.beaconClient.EXPECT().PendingDeposits(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pb.PendingDepositsResponse{}, nil /*err*/)
m.beaconClient.EXPECT().Eth1Data(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pb.Eth1DataResponse{}, nil /*err*/)
m.beaconClient.EXPECT().ForkData(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pbp2p.Fork{
Epoch: params.BeaconConfig().GenesisEpoch,
CurrentVersion: 0,
PreviousVersion: 0,
}, nil /*err*/)
m.proposerClient.EXPECT().PendingAttestations(
gomock.Any(), // ctx
gomock.AssignableToTypeOf(&pb.PendingAttestationsRequest{}),
).Return(&pb.PendingAttestationsResponse{PendingAttestations: []*pbp2p.Attestation{}}, nil)
m.proposerClient.EXPECT().ComputeStateRoot(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Return(nil /*response*/, errors.New("something bad happened"))
validator.ProposeBlock(context.Background(), 55)
testutil.AssertLogsContain(t, hook, "something bad happened")
}
func TestProposeBlock_UsesComputedState(t *testing.T) {
validator, m, finish := setup(t)
defer finish()
m.beaconClient.EXPECT().CanonicalHead(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pbp2p.BeaconBlock{}, nil /*err*/)
m.beaconClient.EXPECT().PendingDeposits(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pb.PendingDepositsResponse{}, nil /*err*/)
m.beaconClient.EXPECT().Eth1Data(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pb.Eth1DataResponse{}, nil /*err*/)
m.beaconClient.EXPECT().ForkData(
gomock.Any(), // ctx
gomock.Eq(&ptypes.Empty{}),
).Return(&pbp2p.Fork{
Epoch: params.BeaconConfig().GenesisEpoch,
CurrentVersion: 0,
PreviousVersion: 0,
}, nil /*err*/)
m.proposerClient.EXPECT().PendingAttestations(
gomock.Any(), // ctx
gomock.AssignableToTypeOf(&pb.PendingAttestationsRequest{}),
).Return(&pb.PendingAttestationsResponse{PendingAttestations: []*pbp2p.Attestation{}}, nil)
var broadcastedBlock *pbp2p.BeaconBlock
m.proposerClient.EXPECT().ProposeBlock(
gomock.Any(), // ctx
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Do(func(_ context.Context, blk *pbp2p.BeaconBlock) {
broadcastedBlock = blk
}).Return(&pb.ProposeResponse{}, nil /*error*/)
computedStateRoot := []byte{'T', 'E', 'S', 'T'}
m.proposerClient.EXPECT().ComputeStateRoot(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Return(
&pb.StateRootResponse{
StateRoot: computedStateRoot,
},
nil, // err
)
validator.ProposeBlock(context.Background(), 55)
if !bytes.Equal(broadcastedBlock.StateRootHash32, computedStateRoot) {
t.Errorf("Unexpected state root hash. want=%#x got=%#x", computedStateRoot, broadcastedBlock.StateRootHash32)
}
}
func TestProposeBlock_BroadcastsABlock(t *testing.T) {
validator, m, finish := setup(t)
defer finish()
@ -341,6 +464,13 @@ func TestProposeBlock_BroadcastsABlock(t *testing.T) {
gomock.AssignableToTypeOf(&pb.PendingAttestationsRequest{}),
).Return(&pb.PendingAttestationsResponse{PendingAttestations: []*pbp2p.Attestation{}}, nil)
m.proposerClient.EXPECT().ComputeStateRoot(
gomock.Any(), // context
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),
).Return(&pb.StateRootResponse{
StateRoot: []byte{'F'},
}, nil /*err*/)
m.proposerClient.EXPECT().ProposeBlock(
gomock.Any(), // ctx
gomock.AssignableToTypeOf(&pbp2p.BeaconBlock{}),

31
validator/client/validator_test.go
View File

@ -288,6 +288,37 @@ func TestCanonicalHeadSlot_OK(t *testing.T) {
}
}
func TestUpdateAssignments_DoesNothingWhenNotEpochStartAndAlreadyExistingAssignments(t *testing.T) {
// TODO(2167): Unskip this test.
t.Skip()
ctrl := gomock.NewController(t)
defer ctrl.Finish()
client := internal.NewMockValidatorServiceClient(ctrl)
slot := uint64(1)
v := validator{
key: validatorKey,
validatorClient: client,
assignment: &pb.CommitteeAssignmentResponse{
Assignment: []*pb.CommitteeAssignmentResponse_CommitteeAssignment{
{
Committee: []uint64{},
Slot: 10,
Shard: 20,
},
},
},
}
client.EXPECT().CommitteeAssignment(
gomock.Any(),
gomock.Any(),
).Times(0)
if err := v.UpdateAssignments(context.Background(), slot); err != nil {
t.Errorf("Could not update assignments: %v", err)
}
}
func TestUpdateAssignments_ReturnsError(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()