mirror/prysm-pulse
1
0
Fork 0
mirror of https://gitlab.com/pulsechaincom/prysm-pulse.git synced 2025-01-12 04:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ForceCheckpoint return early when zero hashes (#6852)

Browse Source 
* Setter: return early with zero hashes
* Test: zero hashes don't panic
* Merge branch 'master' of github.com:prysmaticlabs/prysm
* Merge refs/heads/master into zero-hashes
* Merge refs/heads/master into zero-hashes
* Merge refs/heads/master into zero-hashes
This commit is contained in:
terence tsao 2020-08-03 11:34:54 -07:00 committed by GitHub
parent 69e0e302b3
commit ee7da0d451
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
beacon-chain/state/stategen/setter.go
View File

@ -5,6 +5,7 @@ import (
"github.com/prysmaticlabs/prysm/beacon-chain/state"
"github.com/prysmaticlabs/prysm/shared/bytesutil"
"github.com/prysmaticlabs/prysm/shared/params"
"go.opencensus.io/trace"
)
@ -29,6 +30,12 @@ func (s *State) ForceCheckpoint(ctx context.Context, root []byte) error {
defer span.End()
root32 := bytesutil.ToBytes32(root)
// Before the first finalized check point, the finalized root is zero hash.
// Return early if there hasn't been a finalized check point.
if root32 == params.BeaconConfig().ZeroHash {
return nil
}
fs, err := s.loadHotStateByRoot(ctx, root32)
if err != nil {
return err

5
beacon-chain/state/stategen/setter_test.go
View File

@ -99,4 +99,9 @@ func TestState_ForceCheckpoint_SavesStateToDatabase(t *testing.T) {
if !db.HasState(ctx, r) {
t.Error("Did not save checkpoint to database")
}
// Should not panic with genesis finalized root.
if err := svc.ForceCheckpoint(ctx, params.BeaconConfig().ZeroHash[:]); err != nil {
t.Error(err)
}
}